[BUG] Launcher freezing

[muscularcandy67]

When downloading a new update or the game the launcher will freeze for some reason

and if you try to force close the launcher and then reopen it the launcher will constantly fail to actually locate the installed game. It happened with Honkai Impact 3rd Global, I don't know if it can happen with other game versions, although it's highly likely it can. By the way, in the Task Manager it shows an usage of around 10MB/s while being in that state, and the download actually continues, it just the launcher that freezes

[muscularcandy67]

On a further analysis, seems like the issue is based on the network speed. What I guess happens is that with high speed internet the progress bar updates more frequently, therefore when it's time to redraw the bar it already needs an update, and goes into a loop that results in the launcher UI freezing. My reason? I limited my speed to 4-5MB/s and yes it's taking longer, but no freezes. I will update this comment if it ends up freezing at some point with this speed

[KorewaLidesu]

I'm getting 7MB/s on download but no freezing issue.
Are you install it on HDD or SSD?

[muscularcandy67]

Installing it on an SSD, and I'm sure something happens when on high speed above 7MB/s, not sure at which point starts to freeze, but it happened also while predownloading

[neon-nyan]

Hi @muscularcandy67,

Thank you again for reporting another issue and sorry for my late response since I got busy last week.
I've made an investigation and found that the root cause is the thread blocking on StartWriteSession() method from Hi3Helper.Http submodule while getting intensive call for reading the remote stream.

These changes will be applied in the next hotfix.

Edit:

These changes will be applied for the next preview and stable release and unfortunately will not be planned for hotfix on current stable version, which is 1.0.36.x

[muscularcandy67]

@neon-nyan don't worry about it, everyone has life, plus this is just a personal project for you that you are sharing with us. I'm tho saddened that I encountered two bugs (altho one was really just a small issue) and I was the only one to report them

[neon-nyan]

I just updated the preview build to v1.0.40.5 here:
https://github.com/neon-nyan/CollapseLauncher/releases/tag/CL-v1.0.40.5-pre

You can try it and let me know if this build fixes the issue.

[muscularcandy67]

Okay I actually already compiled the update yesterday before you released it, and I did a test installation on Honkai Impact 3rd SEA and the launcher didn't freeze

[neon-nyan]

Good to hear that. I think we can close this issue for now.