Skip to content

Commit

Permalink
Move Background Instance from static to local
Browse files Browse the repository at this point in the history
  • Loading branch information
@neon-nyan
neon-nyan committed Apr 7, 2024
1 parent 1621e11 commit 025bdf6
Show file tree
Hide file tree
Showing 6 changed files with 104 additions and 71 deletions.
112 changes: 63 additions & 49 deletions CollapseLauncher/Classes/Helper/Background/BackgroundMediaUtility.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ namespace CollapseLauncher.Helper.Background
[SuppressMessage("ReSharper", "IdentifierTypo")]
[SuppressMessage("ReSharper", "PossibleNullReferenceException")]
[SuppressMessage("ReSharper", "AssignNullToNotNullAttribute")]
internal static class BackgroundMediaUtility
internal class BackgroundMediaUtility : IDisposable
{
internal static BackgroundMediaUtility Current { get; private set; }

Check warning on line 23 in CollapseLauncher/Classes/Helper/Background/BackgroundMediaUtility.cs

View workflow job for this annotation

GitHub Actions / Qodana for .NET

Non-nullable member is uninitialized. 

Non-nullable property 'Current' is uninitialized. Consider declaring the property as nullable.

internal enum MediaType
{
Media,
Expand All @@ -36,30 +38,27 @@ internal enum MediaType
internal static readonly string[] SupportedMediaPlayerExt =
[".mp4", ".mov", ".mkv", ".webm", ".avi", ".gif"];

private static FrameworkElement? _parentUI;
private static ImageUI? _bgImageBackground;
private static ImageUI? _bgImageBackgroundLast;
private static MediaPlayerElement? _bgMediaPlayerBackground;
private FrameworkElement? _parentUI;
private ImageUI? _bgImageBackground;
private ImageUI? _bgImageBackgroundLast;
private MediaPlayerElement? _bgMediaPlayerBackground;

private static Grid? _bgAcrylicMask;
private static Grid? _bgOverlayTitleBar;
private Grid? _bgAcrylicMask;
private Grid? _bgOverlayTitleBar;

private static Grid? _parentBgImageBackgroundGrid;
#pragma warning disable CS0169 // Field is never used
private static Grid? _parentBgImageForegroundGrid;
#pragma warning restore CS0169 // Field is never used
private static Grid? _parentBgMediaPlayerBackgroundGrid;
private Grid? _parentBgImageBackgroundGrid;
private Grid? _parentBgMediaPlayerBackgroundGrid;

internal static MediaType CurrentAppliedMediaType = MediaType.Unknown;
internal MediaType CurrentAppliedMediaType = MediaType.Unknown;

private static CancellationTokenSourceWrapper? _cancellationToken;
private static StillImageLoader? _loaderStillImage;
private static MediaPlayerLoader? _loaderMediaPlayer;
private static IBackgroundMediaLoader? _currentMediaLoader;
private CancellationTokenSourceWrapper? _cancellationToken;
private StillImageLoader? _loaderStillImage;
private MediaPlayerLoader? _loaderMediaPlayer;
private IBackgroundMediaLoader? _currentMediaLoader;

private static bool _isCurrentDimmAnimRun;
private static bool _isCurrentUndimmAnimRun;
private static bool _isCurrentRegistered;
private bool _isCurrentDimmAnimRun;
private bool _isCurrentUndimmAnimRun;
private bool _isCurrentRegistered;

private static FileStream? _alternativeFileStream;

Expand All @@ -75,61 +74,76 @@ internal enum MediaType
/// <param name="bgImageGridBackground">The parent <see cref="Grid" /> for Background Image.</param>
/// <param name="bgMediaPlayerGrid">The parent <see cref="Grid" /> for Background Media Player</param>
internal static async Task RegisterCurrent(FrameworkElement? parentUI, Grid bgAcrylicMask,
Grid bgOverlayTitleBar, Grid bgImageGridBackground,
Grid bgMediaPlayerGrid)
Grid bgOverlayTitleBar, Grid bgImageGridBackground,
Grid bgMediaPlayerGrid)
{
// Set the parent UI
_parentUI = parentUI;

// Mask stuff
_bgAcrylicMask = bgAcrylicMask;
_bgOverlayTitleBar = bgOverlayTitleBar;
FrameworkElement? ui = parentUI;

// Initialize the background instances
(_bgImageBackground, _bgImageBackgroundLast) =
var (bgImageBackground, bgImageBackgroundLast) =
await InitializeElementGrid<ImageUI>(bgImageGridBackground, "ImageBackground", AssignDefaultImage);
_bgMediaPlayerBackground =
var bgMediaPlayerBackground =
(await TryGetFirstGridElement<MediaPlayerElement>(bgMediaPlayerGrid.WithOpacity(0), "MediaPlayer"))
.WithHorizontalAlignment(HorizontalAlignment.Center)
.WithVerticalAlignment(VerticalAlignment.Center)
.WithStretch(Stretch.UniformToFill);

// Store the parent grid reference into this static variables
Current = new BackgroundMediaUtility(ui, bgAcrylicMask, bgOverlayTitleBar,
bgImageGridBackground, bgMediaPlayerGrid, bgImageBackground,
bgImageBackgroundLast, bgMediaPlayerBackground);
}

private BackgroundMediaUtility(FrameworkElement? parentUI, Grid bgAcrylicMask,
Grid bgOverlayTitleBar, Grid bgImageGridBackground,
Grid bgMediaPlayerGrid, ImageUI? bgImageBackground,
ImageUI? bgImageBackgroundLast, MediaPlayerElement? mediaPlayerElement)
{
_parentUI = parentUI;
_bgAcrylicMask = bgAcrylicMask;
_bgOverlayTitleBar = bgOverlayTitleBar;
_parentBgImageBackgroundGrid = bgImageGridBackground;
_parentBgMediaPlayerBackgroundGrid = bgMediaPlayerGrid;

_bgImageBackground = bgImageBackground;
_bgImageBackgroundLast = bgImageBackgroundLast;
_bgMediaPlayerBackground = mediaPlayerElement;

// Set that the current page has been registered
_isCurrentRegistered = true;
}

~BackgroundMediaUtility() => Dispose();

/// <summary>
/// Detach the current background utility from the previously attached <see cref="Grid" />.
/// Detach and dispose the current background utility from the previously attached <see cref="Grid" />.
/// </summary>
internal static void DetachCurrent()
public void Dispose()
{
if (_cancellationToken is { IsCancellationRequested: false })
{
_cancellationToken.Cancel();
}
_cancellationToken?.Dispose();

_bgImageBackground = null;
_bgImageBackgroundLast = null;
_bgMediaPlayerBackground = null;

_parentBgImageBackgroundGrid?.ClearChildren();
_parentBgMediaPlayerBackgroundGrid?.ClearChildren();

_parentBgImageBackgroundGrid = null;
_parentBgMediaPlayerBackgroundGrid = null;
_bgAcrylicMask = null;
_bgOverlayTitleBar = null;

_loaderMediaPlayer?.Dispose();
_loaderMediaPlayer = null;
_loaderStillImage?.Dispose();
_loaderStillImage = null;

CurrentAppliedMediaType = MediaType.Unknown;

_isCurrentRegistered = false;
GC.SuppressFinalize(this);
}

/// <summary>
Expand Down Expand Up @@ -237,7 +251,7 @@ internal static async ValueTask AssignDefaultImage<TElement>(TElement element)
/// Ensure that the <see cref="ImageUI" /> instance is already initialized
/// </summary>
/// <exception cref="ArgumentNullException">Throw if <see cref="ImageUI" /> instance is not registered</exception>
private static void EnsureCurrentImageRegistered()
private void EnsureCurrentImageRegistered()
{
if (_bgImageBackground == null || _bgImageBackgroundLast == null)
{
Expand All @@ -249,7 +263,7 @@ private static void EnsureCurrentImageRegistered()
/// Ensure that the <see cref="MediaPlayerElement" /> instance is already initialized
/// </summary>
/// <exception cref="ArgumentNullException">Throw if <see cref="MediaPlayerElement" /> instance is not registered</exception>
private static void EnsureCurrentMediaPlayerRegistered()
private void EnsureCurrentMediaPlayerRegistered()
{
if (_bgMediaPlayerBackground == null)
{
Expand All @@ -265,12 +279,12 @@ private static void EnsureCurrentMediaPlayerRegistered()
/// <param name="isForceRecreateCache">Request a cache recreation if the background file properties have been cached</param>
/// <exception cref="FormatException">Throws if the background file is not supported</exception>
/// <exception cref="NullReferenceException">Throws if some instances aren't yet initialized</exception>
internal static async Task LoadBackground(string mediaPath, bool isRequestInit = false,
internal async Task LoadBackground(string mediaPath, bool isRequestInit = false,
bool isForceRecreateCache = false)
{
while (!_isCurrentRegistered)
{
await Task.Delay(250, _cancellationToken?.Token ?? default);
await Task.Delay(250, _cancellationToken?.Token ?? default);
}

EnsureCurrentImageRegistered();
Expand Down Expand Up @@ -348,7 +362,7 @@ await _currentMediaLoader.LoadAsync(mediaPath, isForceRecreateCache, isRequestIn
/// <summary>
/// Dimming the current loaded background
/// </summary>
internal static async void Dimm()
internal async void Dimm()
{
while (_isCurrentDimmAnimRun || _isCurrentUndimmAnimRun)
{
Expand All @@ -375,7 +389,7 @@ internal static async void Dimm()
/// <summary>
/// Undimming the current loaded background
/// </summary>
internal static async void Undimm()
internal async void Undimm()
{
while (_isCurrentDimmAnimRun || _isCurrentUndimmAnimRun)
{
Expand All @@ -402,55 +416,55 @@ internal static async void Undimm()
/// <summary>
/// Mute the audio of the currently loaded background
/// </summary>
internal static void Mute()
internal void Mute()
{
_currentMediaLoader?.Mute();
}

/// <summary>
/// Unmute the audio of the currently loaded background
/// </summary>
internal static void Unmute()
internal void Unmute()
{
_currentMediaLoader?.Unmute();
}

/// <summary>
/// Set the volume of the audio from the currently loaded background
/// </summary>
internal static void SetVolume(double value)
internal void SetVolume(double value)
{
_currentMediaLoader?.SetVolume(value);
}

/// <summary>
/// Trigger the unfocused window event to the currently loaded background
/// </summary>
internal static void WindowUnfocused()
internal void WindowUnfocused()
{
_currentMediaLoader?.WindowUnfocused();
}

/// <summary>
/// Trigger the focused window event to the currently loaded background
/// </summary>
internal static void WindowFocused()
internal void WindowFocused()
{
_currentMediaLoader?.WindowFocused();
}

/// <summary>
/// Play/Resume the currently loaded background
/// </summary>
internal static void Play()
internal void Play()
{
_currentMediaLoader?.Play();
}

/// <summary>
/// Pause the currently loaded background
/// </summary>
internal static void Pause()
internal void Pause()
{
_currentMediaLoader?.Pause();
}
Expand All @@ -467,7 +481,7 @@ public static void SetAlternativeFileStream(FileStream stream)
_alternativeFileStream = stream;
}

private static IBackgroundMediaLoader? GetImageLoader(MediaType mediaType)
private IBackgroundMediaLoader? GetImageLoader(MediaType mediaType)
{
return mediaType switch
{
Expand Down
25 changes: 19 additions & 6 deletions CollapseLauncher/Classes/Helper/Background/Loaders/MediaPlayerLoader.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@
using Windows.Media.Playback;
using Windows.Storage;
using Windows.Storage.FileProperties;
using Windows.UI;
using CollapseLauncher.Extension;
using CollapseLauncher.Helper.Animation;
using ColorThiefDotNet;
using CommunityToolkit.WinUI;
using CommunityToolkit.WinUI.Animations;
using Hi3Helper;
using Hi3Helper.Shared.Region;
Expand All @@ -24,16 +21,14 @@
using Microsoft.UI.Xaml.Controls;
using Microsoft.UI.Xaml.Media;
using ImageUI = Microsoft.UI.Xaml.Controls.Image;
using Microsoft.UI;
using CollapseLauncher.Helper.Image;

#nullable enable
namespace CollapseLauncher.Helper.Background.Loaders
{
[SuppressMessage("ReSharper", "IdentifierTypo")]
[SuppressMessage("ReSharper", "PossibleNullReferenceException")]
[SuppressMessage("ReSharper", "AssignNullToNotNullAttribute")]
internal class MediaPlayerLoader : IBackgroundMediaLoader
internal class MediaPlayerLoader : IBackgroundMediaLoader, IDisposable
{
private FrameworkElement ParentUI { get; }
private Compositor CurrentCompositor { get; }
Expand All @@ -56,8 +51,12 @@ internal class MediaPlayerLoader : IBackgroundMediaLoader
private SoftwareBitmap? CurrentFrameBitmap { get; set; }
private CanvasImageSource? CurrentCanvasImageSource { get; set; }
private CanvasDevice? CanvasDevice { get; set; }

#if USEDYNAMICVIDEOPALETTE
private CanvasBitmap? CanvasBitmap { get; set; }

#endif

internal MediaPlayerLoader(
FrameworkElement parentUI,
Grid acrylicMask, Grid overlayTitleBar,
Expand All @@ -82,6 +81,20 @@ internal MediaPlayerLoader(
IsMediaPlayerLoading = false;
}

~MediaPlayerLoader() => Dispose();

public void Dispose()
{
CurrentMediaPlayer?.Dispose();
CurrentStopwatch?.Stop();
InnerCancellationToken?.Dispose();
CurrentFrameBitmap?.Dispose();
CanvasDevice?.Dispose();
CurrentMediaStream?.Dispose();

GC.SuppressFinalize(this);
}

public async ValueTask LoadAsync(string filePath, bool isImageLoadForFirstTime, bool isRequestInit,
CancellationToken token)
{
Expand Down
9 changes: 8 additions & 1 deletion CollapseLauncher/Classes/Helper/Background/Loaders/StillImageLoader.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace CollapseLauncher.Helper.Background.Loaders
[SuppressMessage("ReSharper", "IdentifierTypo")]
[SuppressMessage("ReSharper", "PossibleNullReferenceException")]
[SuppressMessage("ReSharper", "AssignNullToNotNullAttribute")]
internal class StillImageLoader : IBackgroundMediaLoader
internal class StillImageLoader : IBackgroundMediaLoader, IDisposable
{
private FrameworkElement ParentUI { get; }
private Compositor CurrentCompositor { get; }
Expand Down Expand Up @@ -56,6 +56,13 @@ internal StillImageLoader(
IsImageLoading = false;
}

~StillImageLoader() => Dispose();

public void Dispose()
{
GC.SuppressFinalize(this);
}

public async ValueTask LoadAsync(string filePath, bool isImageLoadForFirstTime, bool isRequestInit,
CancellationToken token)
{
Expand Down
Loading

0 comments on commit 025bdf6

Please sign in to comment.