Skip to content

[SANITIZE PHASE] UI Changes and Runtime Improvements (Part 2) #165

[SANITIZE PHASE] UI Changes and Runtime Improvements (Part 2)

[SANITIZE PHASE] UI Changes and Runtime Improvements (Part 2) #165

Triggered via pull request April 5, 2024 06:58
Status Success
Total duration 5m 39s
Artifacts

qodana-scan-pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

289 warnings
Possible 'null' assignment to non-nullable entity: Hi3Helper.EncTool/Hashes/mhyEncTool.cs#L136
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L206
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity: Hi3Helper.EncTool/Hashes/mhyEncTool.cs#L136
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L967
Possible 'null' assignment to non-nullable entity
Incorrect indent (around child statement): Hi3Helper.EncTool/Hashes/HexTool.cs#L85
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Incorrect indent (around child statement): Hi3Helper.EncTool/Parser/XMFParser/Class/XMFAsset.cs#L102
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Incorrect indent (around child statement): Hi3Helper.EncTool/Parser/XMFParser/Class/XMFAsset.cs#L103
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Incorrect indent (around child statement): Hi3Helper.EncTool/Parser/KianaDispatch/KianaDispatch.cs#L103
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Incorrect indent (around child statement): Hi3Helper.EncTool/Hashes/HexTool.cs#L121
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Incorrect indent (around child statement): Hi3Helper.EncTool/Hashes/HexTool.cs#L122
Line is not indented relative to the previous line around child statement, expected indent 4 spaces
Possible null reference argument for a parameter.: CollapseLauncher/Classes/InstallManagement/BaseClass/InstallManagerBase.cs#L1416
Possible null reference argument for parameter 'path2' in 'System.IO.Path.Combine'
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L957
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L1590
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L206
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L205
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L1589
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L958
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L1843
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.: CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs#L1844
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
Conditional access qualifier expression is not null according to nullable reference types' annotations: Hi3Helper.EncTool/Parser/KianaDispatch/KianaDispatch.cs#L66
Conditional access qualifier expression is never null according to nullable reference types' annotations
Conditional access qualifier expression is not null according to nullable reference types' annotations: CollapseLauncher/Classes/Helper/Metadata/LauncherMetadataHelper.cs#L324
Conditional access qualifier expression is never null according to nullable reference types' annotations
Use null check pattern instead of a type check succeeding on any not-null value: Hi3Helper.EncTool/Misc/ConverterTool.cs#L284
Use not null pattern instead of a type check succeeding on any not-null value
Use null check pattern instead of a type check succeeding on any not-null value: Hi3Helper.EncTool/Misc/ConverterTool.cs#L282
Use not null pattern instead of a type check succeeding on any not-null value
Empty general catch clause: CollapseLauncher/Classes/Helper/Background/BackgroundMediaUtility.cs#L363
Empty general catch clause suppresses any errors
Empty general catch clause: CollapseLauncher/Classes/Helper/Background/BackgroundMediaUtility.cs#L387
Empty general catch clause suppresses any errors
Heuristically unreachable code: Hi3Helper.EncTool/Misc/TypeExtensions.cs#L55
Code is heuristically unreachable
Heuristically unreachable code: Hi3Helper.EncTool/Misc/ConverterTool.cs#L263
Code is heuristically unreachable
Heuristically unreachable code: Hi3Helper.EncTool/Misc/ConverterTool.cs#L259
Code is heuristically unreachable
Possible overflow in unchecked context: Hi3Helper.EncTool/Hashes/mhyEncTool.cs#L189
Possible overflow in unchecked context
Possible overflow in unchecked context: Hi3Helper.EncTool/Hashes/mhyEncTool.cs#L116
Possible overflow in unchecked context
Possible overflow in unchecked context: Hi3Helper.EncTool/Hashes/mhyEncTool.cs#L255
Possible overflow in unchecked context
Invalid XML documentation comment: Hi3Helper.EncTool/Parser/XMFParser/Class/XMFUtility.cs#L24
Parameter 'xmfFS' has no matching param tag in the XML comment for Hi3Helper.EncTool.Parser.AssetMetadata.XMFUtility.GetXMFVersion (but other parameters do)
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L249
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L235
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L242
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L256
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Streams/CacheStream/CacheStream.cs#L61
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L228
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L263
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/UABT/UABT/AssetBundle/TextAsset.cs#L35
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/XMFParser/Class/XMFUtility.cs#L30
Return value of method is not used. Fewer bytes can be read than requested
Return value of [MustUseReturnValue] annotated method is not used: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L271
Return value of method is not used. Fewer bytes can be read than requested
Non-accessed field (private accessibility): Hi3Helper.EncTool/Streams/CacheStream/CacheStream.cs#L23
Field '_allowDispose' is assigned but its value is never used
Non-accessed local variable: Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/Lua/SRLuaMetadata.cs#L28
Local variable 'ver' is only assigned but its value is never used
Non-accessed local variable: Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/SRAMBMMetadataReader/SRAMBMMetadataReader.cs#L80
Local variable 'numA4' is only assigned but its value is never used
Non-accessed local variable: Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/SRAMBMMetadataReader/SRAMBMMetadataReader.cs#L81
Local variable 'numA5' is only assigned but its value is never used
Non-accessed local variable: Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/SRAMBMMetadataReader/SRAMBMMetadataReader.cs#L79
Local variable 'numA3' is only assigned but its value is never used
Non-accessed local variable: Hi3Helper.EncTool/Hashes/mhyEncTool.cs#L108
Local variable '_0041' is only assigned but its value is never used
Cannot resolve symbol in text argument: Hi3Helper.EncTool/Streams/ChunkStream.cs#L30
Cannot resolve symbol 'Offset is out of stream size range!'
Mismatch of optional parameter value in overridden method: Hi3Helper.EncTool/Streams/ChunkStream.cs#L54
Parameter cancellationToken in base method 'ValueTask ReadAsync(Memory, CancellationToken)' has default value
Mismatch of optional parameter value in overridden method: Hi3Helper.EncTool/Streams/ChunkStream.cs#L98
Parameter cancellationToken in base method 'ValueTask WriteAsync(ReadOnlyMemory, CancellationToken)' has default value
Parameter hides member: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L12
Parameter 'Padding' hides field 'RSAEncryptionPadding Hi3Helper.EncTool.YSDispatchDec.Padding'
Parameter hides member: Hi3Helper.EncTool/UABT/LZ4/LZ4DecoderStream.cs#L93
Parameter 'input' hides field 'Stream Hi3Helper.UABT.LZ4.LZ4DecoderStream.input'
Parameter hides member: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L12
Parameter 'EncBitlength' hides field 'int Hi3Helper.EncTool.YSDispatchDec.EncBitlength'
Parameter hides member: Hi3Helper.EncTool/UABT/LZ4/LZ4DecoderStream.cs#L93
Parameter 'inputLength' hides field 'long Hi3Helper.UABT.LZ4.LZ4DecoderStream.inputLength'
The source expression always matches the provided pattern: Hi3Helper.EncTool/Misc/ConverterTool.cs#L280
The source expression always matches the provided pattern
Possible 'System.NullReferenceException': Hi3Helper.EncTool/Misc/TypeExtensions.cs#L65
Possible 'System.NullReferenceException'
Possible 'System.NullReferenceException': Hi3Helper.EncTool/Misc/TypeExtensions.cs#L64
Possible 'System.NullReferenceException'
Assignment is not used: Hi3Helper.EncTool/Hashes/HexTool.cs#L117
Value assigned is not used in any execution path
Assignment is not used: CollapseLauncher/Classes/Helper/Metadata/DataCooker.cs#L55
Value assigned is not used in any execution path
Assignment is not used: Hi3Helper.EncTool/Streams/SpanStream.cs#L31
Value assigned is not used in any execution path
Assignment is not used: Hi3Helper.EncTool/WindowTool/ResizableWindowHook/ResizableWindowHook.cs#L17
Value assigned is not used in any execution path
Assignment is not used: Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/Lua/SRLuaMetadata.cs#L32
Value assigned is not used in any execution path
Redundant 'base.' qualifier: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L15
Qualifier 'base.' is redundant
Redundant 'base.' qualifier: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L27
Qualifier 'base.' is redundant
Redundant 'base.' qualifier: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L40
Qualifier 'base.' is redundant
Redundant 'base.' qualifier: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L14
Qualifier 'base.' is redundant
Redundant 'base.' qualifier: Hi3Helper.EncTool/Hashes/YSDispatchDec.cs#L27
Qualifier 'base.' is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L422
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L382
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L201
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L315
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L339
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L410
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L340
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L166
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L314
The nullable warning suppression expression is redundant
Redundant nullable warning suppression expression: CollapseLauncher/Classes/Helper/Metadata/PresetConfig.cs#L230
The nullable warning suppression expression is redundant
Redundant type declaration body: Hi3Helper.EncTool/Parser/Senadina/JsonContext.cs#L7
Redundant empty class declaration body
Redundant using directive: Hi3Helper.EncTool/UABT/LZ4/LZ4CodecHelperEncodeDecode.cs#L1
Using directive is not required by the code and can be safely removed
Redundant using directive: CollapseLauncher/Classes/CachesManagement/Honkai/Fetch.cs#L12
Using directive is not required by the code and can be safely removed
Redundant using directive: Hi3Helper.EncTool/Misc/ConverterTool.cs#L3
Using directive is not required by the code and can be safely removed
Redundant using directive: Hi3Helper.EncTool/UABT/UABT/AssetBundle/Structs/Binary/EndianBinaryReader.cs#L2
Using directive is not required by the code and can be safely removed
Redundant using directive: CollapseLauncher/Program.cs#L10
Using directive is not required by the code and can be safely removed
Redundant using directive: CollapseLauncher/Classes/Properties/InnerLauncherConfig.cs#L18
Using directive is not required by the code and can be safely removed
Redundant using directive: Hi3Helper.EncTool/UABT/UABT/AssetBundle/Structs/Binary/BinaryReaderExtensions.cs#L4
Using directive is not required by the code and can be safely removed
Redundant using directive: Hi3Helper.EncTool/WindowTool/ResizableWindowHook/PInvoke.cs#L1
Using directive is not required by the code and can be safely removed
Unused local variable: Hi3Helper.EncTool/Parser/CacheParser/CGMetadata.cs#L167
Local variable 'ptrToPckType' is never used
Unused local variable: CollapseLauncher/Classes/Helper/Metadata/LauncherMetadataHelper.cs#L246
Local variable 'configFileLastModified' is never used
Unused local variable: Hi3Helper.EncTool/Misc/ConverterTool.cs#L120
Local variable 'inputSignedPtr' is never used
Unused local variable: Hi3Helper.EncTool/Parser/AssetIndex/AssetIndexV2.cs#L118
Local variable 'read' is never used
Unused local variable: CollapseLauncher/Classes/Helper/Metadata/GameDataVersion.cs#L18
Local variable 'dataWritten' is never used
qodana
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.