Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests refactor to separate DBMS/driver tests #701

Merged
merged 16 commits into from
Oct 11, 2023
Merged

Integration tests refactor to separate DBMS/driver tests #701

merged 16 commits into from
Oct 11, 2023

Conversation

Ste1io
Copy link
Collaborator

@Ste1io Ste1io commented Oct 7, 2023 •
edited
Loading

Refactors PetaPoco's integration tests to improve maintainability and consistency across the codebase.

  • Restructured driver tests for:
    • SqlServer [System.Data][Microsoft.Data]
    • SQLite [System.Data][Microsoft.Data]
  • Introduced IExceptionDatabaseProvider interface for PreExecuteTests.
  • Updated MSAccess' test runner to programmatically generate PetaPoco.accdb, eliminating the need to tow around an extra build artifact.
  • Fixed filename, namespace, and class naming inconsistencies across integration tests.
  • Clarified Documentation test comments (possible ambiguity with "they are the same" terminology), use Shouldly's ReferenceEqual assertion instead of object.Equals, use Should.NotThrowAsync for .NET Core targets.
  • Updated project dependencies for PetaPoco.Tests.Integration: Shouldly, xUnit, and Newtonsoft.Json.
  • Standardized RDBMS provider file naming.
  • Added .vscode extensions for C# development and Docker support.

Closes #698

Ste1io added 16 commits October 3, 2023 13:36
@Ste1io
create .vscode extensions for C# dev & docker
451af3f
@Ste1io
fix rdbms provider file naming conventions
9cca3c0
@Ste1io
fix Documentation tests:
10a0d32 
- fix naming inconsistencies
- rename poco member to avoid ambiguity with Shouldly method
- replace equality check with Shouldly's ReferenceEqual assertion method to show clearer intent
- rephrase "they are the same" comments to avoid confusion between reference equality and value equality
@Ste1io
fix test file name inconsistencies:
da96d5b 
- BaseDatabase.cs -> BaseDbContext.cs
- DBTestProvider.cs -> BaseDbProviderFactory.cs

- MariaDb -> MariaDb
- MsAccess -> MSAccess
- Mssql -> SqlServer
- MssqlCe -> SqlServerCe
- MssqlMsData -> SqlServerMSData
- Sqlite -> SQLite
@Ste1io
fixup strings to match updated filepaths
41c6b42 
revert previous MSAccess data type change
@Ste1io
fix Databases tests
ba35e28 
- update namespaces
- update derived Database class names
- update derived DbProviderFactory class names
@Ste1io
update integration test project dependencies:
3bf3209 
- Shouldly, xUnit, Newtonsoft.Json

update PetaPoco.csproj nuget tags
@Ste1io
generate MSAccess .accdb file programmatically
77acb79
@Ste1io
use Should.NotThrowAsync for netcoreapp targets
2755a11 
minor cleanup of base base context/provider classes
@Ste1io
restructure driver tests for SqlServer
43d0c30 
create IExceptionDatabaseProvider.cs
@Ste1io
rename DbProviderFactory -> TestProviders
dda2804 
move TestProviders to Providers namespace/dir
@Ste1io
update csproj:
9fd2fbc 
- add test project properties
- sort package references
@Ste1io
update PreExecuteTests
93b475d
@Ste1io
update DatabaseProvider class doc comments
d51ec32
@Ste1io
fix minor formatting inconsistencies and typos
e22dbab 
update SqlCe PreExecute Tests for completeness
update SqlServer catalog name in cxn strings
@Ste1io
split SQLite driver TestProviders:
4d1184a 
- make SQLiteTestProvider abstract
- create SQLiteSystemDataTestProvider
- create SQLiteMSDataTestProvider
@Ste1io Ste1io requested review from asherber and pleb October 9, 2023 19:12
@Ste1io Ste1io marked this pull request as ready for review October 9, 2023 19:13
@Ste1io Ste1io mentioned this pull request Oct 11, 2023
Open
9 tasks
@pleb pleb merged commit 53e928c into CollaboratingPlatypus:development Oct 11, 2023
@pleb
Copy link
Member

pleb commented Oct 11, 2023

@Ste1io I didn't go through all the changes, but I trust you, and what I did look at was good... so I hit merge :)

Thanks for all the great work you've been contributing

@Ste1io
Copy link
Collaborator Author

Ste1io commented Oct 11, 2023

Much appreciated, @pleb.

@Ste1io Ste1io added this to the 6.2 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asherber asherber Awaiting requested review from asherber

@pleb pleb Awaiting requested review from pleb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

Refactor Integration Tests to separate DBMS tests from driver tests
2 participants
@Ste1io @pleb