Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calc): Improve grid colors in dark mode #10575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 22, 2024

Change-Id: Ie379efb16f5e82de8d53203b88fdccad15e8da37

  • Resolves: #
  • Target version: master

Summary

This allow to adjust the calc grid line color through css variables. It also sets a different value for dark mode to make the contrast ratio with the background similar to light mode.

Change might be subtle but makes calc in dark mode look much nicer as discussed at some point already with @pedropintosilva and @jancborchardt

One issue seems still that a reload is required, on switching to dark mode the grid color is not picked up again. I'm not sure what the best way would be to update the sectionProperties values in that case. Maybe someone has a pointer there?

Before After
image image
image image

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Julius Härtl <[email protected]>
Change-Id: Ie379efb16f5e82de8d53203b88fdccad15e8da37
@juliusknorr juliusknorr added design bug Something isn't working labels Nov 22, 2024
@juliusknorr juliusknorr self-assigned this Nov 22, 2024
@pedropintosilva
Copy link
Contributor

Pressed Retry test

@juliusknorr
Copy link
Member Author

Could be a follow up but that would still be interesting:

One issue seems still that a reload is required, on switching to dark mode the grid color is not picked up again. I'm not sure what the best way would be to update the sectionProperties values in that case. Maybe someone has a pointer there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design
Projects
Status: To Test
Development

Successfully merging this pull request may close these issues.

2 participants