fix(calc): Improve grid colors in dark mode #10575
Open
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie379efb16f5e82de8d53203b88fdccad15e8da37
Summary
This allow to adjust the calc grid line color through css variables. It also sets a different value for dark mode to make the contrast ratio with the background similar to light mode.
Change might be subtle but makes calc in dark mode look much nicer as discussed at some point already with @pedropintosilva and @jancborchardt
One issue seems still that a reload is required, on switching to dark mode the grid color is not picked up again. I'm not sure what the best way would be to update the sectionProperties values in that case. Maybe someone has a pointer there?
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay