Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Plex plugin: initial bring up #135

Merged
merged 17 commits into from
Nov 5, 2017
Merged

Plex plugin: initial bring up #135

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7e844a2
Plex plugin: initial bring up
Oct 20, 2017
3a17c68
Plex plugin: fix artUrl
Oct 20, 2017
a4d330c
Plex plugin: artUrl is now a data-url
Oct 23, 2017
e633080
Plex plugin: fix media keys
Oct 23, 2017
c572dac
Plex plugin: less obnoxious color scheme
Oct 23, 2017
715e896
Plex plugin: code cleanup, support songDuration & songPosition
Oct 25, 2017
5f46382
Plex plugin: use plex's color scheme as theme
Oct 25, 2017
df398bc
Plex plugin: make use of MellowPlayer's utility functions
Oct 26, 2017
8b892eb
plex plugin: set correct version number
Oct 26, 2017
b13eff1
Plex plugin: fetch blobs as base64 image
Oct 29, 2017
bd37210
Plex plugin: set artUrl
Oct 29, 2017
aa8c341
Plex plugin: re-add mediaInfoElement
Oct 29, 2017
1f15d5e
Plex plugin: remove debug console.log calls
Oct 29, 2017
b6b5408
Plex plugin: beautify
Oct 29, 2017
5bb27d7
Plex plugin: use hash instead of actual title as identifier
Oct 29, 2017
a3fd9b3
Plex plugin: only assign previousSongHash when sucessfully got artUrl
Nov 4, 2017
ce7d066
Revert "Plex plugin: only assign previousSongHash when sucessfully go…
Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions plugins/plex/integration.js
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,19 @@ function update() {
var albumTitle = '';
}

var mediaArtElement = mediaInfoElement.children[
0].children[0].children[0].children[0].children[0].children[0]
var songHash = getHashCode(songTitle)

if (songHash !== previousSongHash) {
previousSongHash = songHash
artUrl = "";
convertArtUrlToBase64();
}
if (mediaArtElement)
if (songHash !== previousSongHash) {
artUrl = "";
convertArtUrlToBase64();
if (artUrl === "" )
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convertArtUrlToBase64 is asynchronous and set the global artUrl variable later when the response to the XmlHttpRequest has been received and the content loaded by the FileReader. So resetting previousSongHash would cause many redundant request while the response of the first one has not been received.

previousSongHash = ""
else
previousSongHash = songHash
}

var updateInfo = {
"playbackStatus": playbackStatus,
Expand Down