Use SYSTEM include directories for 3rdparties include dirs

Hopefully this will fix warnings coming from Qt with GCC8 (see #193)

CMakeLists.txt

@@ -43,7 +43,7 @@ if (UNIX AND NOT APPLE)
 endif()
 
 include(cmake/FindDependencies.cmake)
-include_directories(3rdparty)
+include_directories(SYSTEM 3rdparty)
 # Sources
 if(ENABLE_COVERAGE)
     include(cmake/CodeCoverage.cmake)

cmake/FindDependencies.cmake

@@ -16,19 +16,19 @@ find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS
              WebEngineWidgets
              Widgets)
 find_package(Qt5LinguistTools REQUIRED)
-include_directories(${Qt5Core_INCLUDE_DIRS})
-include_directories(${Qt5Concurren_INCLUDE_DIRS})
-include_directories(${Qt5Gui_INCLUDE_DIRS})
-include_directories(${Qt5Network_INCLUDE_DIRS})
-include_directories(${Qt5Qml_INCLUDE_DIRS})
-include_directories(${Qt5Quick_INCLUDE_DIRS})
-include_directories(${Qt5QuickControls2_INCLUDE_DIRS})
-include_directories(${Qt5Sql_INCLUDE_DIRS})
-include_directories(${Qt5Svg_INCLUDE_DIRS})
-include_directories(${Qt5Test_INCLUDE_DIRS})
-include_directories(${Qt5WebEngine_INCLUDE_DIRS})
-include_directories(${Qt5WebEngineWidgets_INCLUDE_DIRS})
-include_directories(${Qt5Widgets_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Core_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Concurren_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Gui_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Network_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Qml_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Quick_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5QuickControls2_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Sql_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Svg_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Test_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5WebEngine_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5WebEngineWidgets_INCLUDE_DIRS})
+include_directories(SYSTEM ${Qt5Widgets_INCLUDE_DIRS})
 
 
 if (UNIX AND NOT APPLE)

tests/CMakeLists.txt

@@ -1,6 +1,6 @@
 include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/3rdparty/catch)
 include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/3rdparty/fakeit)
-include_directories(${CMAKE_SOURCE_DIR}/3rdparty/gtest-gmock)
+include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/3rdparty/gtest-gmock)
 include_directories(../src/lib)
 include_directories(.)
 include_directories(Lib)