Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gulp4 #150

Closed
wants to merge 6 commits into from
Closed

Update to Gulp4 #150

wants to merge 6 commits into from

Conversation

rejas
Copy link

@rejas rejas commented Mar 27, 2018

Hi, I saw an old PR (thx to @erulabs for that) that didnt got updated to the final gulp4 release. Took some inspiration from it and cleaned up the code a little. Comments welcome @JacksonGariety

@xtforgame
Copy link

xtforgame commented Mar 28, 2018

Well done @rejas

I just doing the same thing and the different part is that I put the cb function in the start event, like this way:

var called = false;

gulp.task('test', gulp.series('lint', function gulp_nodemon (cb) {
  stream
    .on('start', function () {
      if (!called) {
        called = true;
        cb(); <===
      }
    })

But I think it makes no significant difference to most cases :)

@rifler
Copy link

rifler commented Mar 30, 2018

waiting for this...

@rejas
Copy link
Author

rejas commented May 3, 2018

Hi @JacksonGariety since there is no activity from you, do you plan on maintaining this repo or can we somehow help you?

@erulabs
Copy link

erulabs commented May 3, 2018

PR looks good to me! Also would be willing to help maintain the repo if some help is needed

# Conflicts:
#	README.md
#	gulpfile.js
#	package.json
@rejas
Copy link
Author

rejas commented May 31, 2018

Closing this since #151 got merged

@rejas rejas closed this May 31, 2018
@rejas rejas deleted the gulp4 branch July 27, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants