Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart the scheduler to call configure again to get new tasks #588

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

elpete
Copy link
Contributor

@elpete elpete commented Jan 31, 2024

Description

This PR adds a restart method to Schedulers so we can dynamically load tasks in the configure method.

restart will shutdown the Scheduler, clear the tasks, call configure, and then startup the scheduler.

Type of change

Please delete options that are not relevant.

  • Bug Fix
  • Improvement
  • New Feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project cfformat
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Jan 31, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit bad8d8f.

♻️ This comment has been updated with latest results.

Copy link
Member

@lmajano lmajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple change and ready to go

system/web/services/SchedulerService.cfc Outdated Show resolved Hide resolved
@elpete elpete force-pushed the scheduler_restart branch from 669f6ed to 63eae13 Compare February 2, 2024 18:22
@lmajano lmajano merged commit 788f64f into development Feb 9, 2024
5 of 19 checks passed
@lmajano lmajano deleted the scheduler_restart branch February 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants