Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4x: Starting to flesh out SSVM integration #721

Closed
wants to merge 10 commits into from
Closed

Conversation

Col-E
Copy link
Owner

@Col-E Col-E commented Sep 18, 2023

Services offered

  • CommonVirtualService - Housing the shared VM instance
  • VirtualInvoker - Invoking method in the shared VM instance and reporting back what the return values were
  • VirtualOptimizer - Invoking methods with optimzer passes and reporting back an optimized version of methods where possible

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Unit Test results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 42f635c. ± Comparison against base commit ea1063f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Unit test results

269 tests  +3   263 ✅ +3   17s ⏱️ -2s
 46 suites +1     6 💤 ±0 
 46 files   +1     0 ❌ ±0 

Results for commit 382ff62. ± Comparison against base commit 76f2ac3.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: Patch coverage is 44.53961% with 259 lines in your changes are missing coverage. Please review.

Project coverage is 66.07%. Comparing base (ad3e121) to head (382ff62).
Report is 12 commits behind head on dev4.

❗ Current head 382ff62 differs from pull request most recent head 62c8afc. Consider uploading reports for the commit 62c8afc to get more accurate results

Files Patch % Lines
.../coley/recaf/services/vm/CommonVirtualService.java 36.47% 94 Missing and 14 partials ⚠️
...ley/recaf/util/io/BufferDelegatingPrintStream.java 17.00% 82 Missing and 1 partial ⚠️
...tware/coley/recaf/services/vm/ArgumentBuilder.java 41.17% 56 Missing and 4 partials ⚠️
.../java/software/coley/recaf/services/vm/VmTest.java 87.23% 6 Missing ⚠️
...ftware/coley/recaf/services/vm/VirtualInvoker.java 90.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               dev4     #721      +/-   ##
============================================
+ Coverage     62.34%   66.07%   +3.72%     
- Complexity     2445     2454       +9     
============================================
  Files           300      328      +28     
  Lines         11442    14405    +2963     
  Branches       1600     1619      +19     
============================================
+ Hits           7134     9518    +2384     
- Misses         3557     4147     +590     
+ Partials        751      740      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Col-E
Copy link
Owner Author

Col-E commented Jun 4, 2024

Due to lack of available time maintaining SSVM and its per-version backend for each new JDK release we will be migrating to a system similar to SSVM, but not as crazy accurate. This will allow us to have the same API capabilities we want in Recaf but not have to worry about updating SSVM internals when hotspot backend changes occur each release. Maintaining SSVM is just not long-term sustainable with just hobby time. Its an amazing tool/library but is sadly something we'll need to step away from.

@Col-E Col-E closed this Jun 4, 2024
@Col-E Col-E deleted the feature/4x-ssvm branch June 6, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants