fix:(DOS-1442)Termination of pull transfer process from consumer side not success in real but stated as "TERMINATED" #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested changes
Dec 18, 2024
.../edc/connector/controlplane/services/transferprocess/TransferProcessProtocolServiceImpl.java
Outdated
Show resolved
Hide resolved
.../edc/connector/controlplane/services/transferprocess/TransferProcessProtocolServiceImpl.java
Outdated
Show resolved
Hide resolved
.../connector/controlplane/services/transferprocess/TransferProcessProtocolServiceImplTest.java
Outdated
Show resolved
Hide resolved
.../testFixtures/java/org/eclipse/edc/connector/controlplane/test/system/utils/Participant.java
Outdated
Show resolved
Hide resolved
.../testFixtures/java/org/eclipse/edc/connector/controlplane/test/system/utils/Participant.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
requested changes
Dec 19, 2024
.../edc/connector/controlplane/services/transferprocess/TransferProcessProtocolServiceImpl.java
Outdated
Show resolved
Hide resolved
.../edc/connector/controlplane/services/transferprocess/TransferProcessProtocolServiceImpl.java
Outdated
Show resolved
Hide resolved
.../testFixtures/java/org/eclipse/edc/connector/controlplane/test/system/utils/Participant.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
requested changes
Dec 20, 2024
There was a problem hiding this comment.
I think the method scopes are a bit clunky, in a test the highlights should stay in the test main method, e.g. (pseudocode for terminateByProvider_httpPull_dataTransfer):
start transfer (after this method the transfer will be started
assert data is accessible
terminate transfer
await consumer to be terminated
await provider to be deprovisioned
assert data is not accessible anymore
.../edc/connector/controlplane/services/transferprocess/TransferProcessProtocolServiceImpl.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
previously approved these changes
Dec 20, 2024
| return assetId; | ||
| } | ||
|
|
||
| private StartedTransferContext assertTransferProcessIsStarted(String assetId){ |
There was a problem hiding this comment.
Suggested change
| private StartedTransferContext assertTransferProcessIsStarted(String assetId){ | |
| private StartedTransferContext startTransferProcess(String assetId){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Start termination process from data flow manager for provider when termination initiated by consumer
Why it does that
During the termination of PULL transfer process from consumer, system does not call method terminate() from DataFlowManager on provider side.
As a result process not terminated in real but transfer process had state "TERMINATED", and then it is not possible to initiate terminating process again not from consumer neither form provider side.
Further notes
After provider moved to TERMINATED state, it also should move to the DEPROVISIONING automatically
Linked Issue(s)
Closes #4637
Closes DOS-1442