Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DOS-1413 error while resume PULL transfer from provider #1

Closed

Conversation

AndrYurk
Copy link

What this PR changes/adds
Adds a "SUSPENDED" state to the list of allowed states to be started consumer

Why it does that
To allow the provider resume the transfer without exceptions.

Further notes
To make possible create e2e test by provider commands, method awaitTransferToBeInState from TransferEndToEndTestBase was unified.

Linked Issue(s)

Part of Cofinity-X https://cofinity-x.atlassian.net/browse/DOS-1413
Part of upstream eclipse-edc#4591

@AndrYurk AndrYurk requested a review from ndr-brt as a code owner November 21, 2024 08:38
Copy link

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 nits about testing, but for the rest it could be ready to go. 🚀
Let's see how it appears after applying the suggestion.

@AndrYurk
Copy link
Author

@ndr-brt PR has been updated, please review

@AndrYurk AndrYurk requested a review from ndr-brt November 22, 2024 08:51
Copy link

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

@AndrYurk AndrYurk requested a review from ndr-brt November 24, 2024 17:24
Copy link

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side this is ready to be opened upstream 🙌

@AndrYurk AndrYurk closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants