-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DOS-1413 error while resume PULL transfer from provider #1
Conversation
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferEndToEndTestBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 2 nits about testing, but for the rest it could be ready to go. 🚀
Let's see how it appears after applying the suggestion.
...test/java/org/eclipse/edc/connector/controlplane/transfer/spi/types/TransferProcessTest.java
Outdated
Show resolved
Hide resolved
tests improvement
@ndr-brt PR has been updated, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there
...transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferEndToEndParticipant.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/edc/connector/controlplane/transfer/spi/types/TransferProcessTest.java
Outdated
Show resolved
Hide resolved
tests improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side this is ready to be opened upstream 🙌
What this PR changes/adds
Adds a "SUSPENDED" state to the list of allowed states to be started consumer
Why it does that
To allow the provider resume the transfer without exceptions.
Further notes
To make possible create e2e test by provider commands, method awaitTransferToBeInState from TransferEndToEndTestBase was unified.
Linked Issue(s)
Part of Cofinity-X https://cofinity-x.atlassian.net/browse/DOS-1413
Part of upstream eclipse-edc#4591