Fix/do 4418 wrong spelling of the column catenax site id in the table assets as planned #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
hgo-ds
requested review from
martin-fritz,
ds-jkreutzfeld,
ds-asmierzchalski,
ramnarayan-cofinityx and
mauantoniojw
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
...rc/test/java/org/eclipse/tractusx/traceability/integration/common/support/AssetTestData.java
Show resolved
Hide resolved
...ctusx/traceability/assets/infrastructure/base/irs/model/response/semanticdatamodel/Site.java
Show resolved
Hide resolved
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
- Consolidation on catenaXSiteId - but the interfaces are tolerant with the spelling Because the existing possibilities of different spellings of the catenaXSiteId attribute cannot be resolved with certainty, and the uncertainty of a change remains, all relevant places are implemented in the TRX regardless of the spelling.
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
* chore: [DO-1578] stash changes * [DO-1578][major] : Implementation of quality investigations designs and table column settings * chore: [DO-1578] stash progress * chore: [DO-1578] stashing progress * chore: [DO-1578] Fixed merge conflicts * chore: [DO-1578] Fixed failing unit tests * chore: [DO-1579] fix code duplication * chore: [DO-1579] PR feedback * chore: [DO-1579] Fix duplication * chore: [DO-1579] PR feedback * chore: [DO-1578] Fixed gap next to table * chore: [DO-1579] Cleanup
* feature: changed the display of the multi sort and the tool tip * fix: alerts received not sorted correctly in the beginning. Also fixed the tooltip showing on the dashboard where sorting is not possible * fix: dashboard table takes the height of the my parts table. * fix: tests and duplication * fix: test * fix: test * fix: duplication * fix: more test things
fix: changed the default time out for the async functions running test with time elements that could take longer than 5 seconds to completely load.
* chore: [DO-1578] stash changes * [DO-1578][major] : Implementation of quality investigations designs and table column settings * chore: [DO-1578] stash progress * chore: [DO-1578] stashing progress * chore: [DO-1578] Fixed merge conflicts * chore: [DO-1578] Fixed failing unit tests * chore: [DO-1579] fix code duplication * chore: [DO-1579] PR feedback * chore: [DO-1579] Fix duplication * chore: [DO-1579] PR feedback * chore: [DO-1578] Fixed gap next to table * chore: [DO-1579] Cleanup * feature: [DO-1582] Implemented shared parts figma designs * chore: [DO-1582] PR feedback * chore: [DO-1582] PR feedback * chore: [DO-1582] Cleanup * chore: [DO-1582]: PR feedback
* fix: changed the testing to only test what is in the component since the rendering could take some time in the tests. * chore: clean up of the old test that were commented out so that in case of errors the old test could be checked
resolve conflict
allow all mutations of the catenaXSiteId attribute
- Review Feedback - drop unused code
hgo-ds
force-pushed
the
fix/DO-4418-wrong-spelling-of-the-column-catenax_site_id-in-the-table-assets_as_planned
branch
from
188a7d2 to
44070fe
Compare
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
hgo-ds
temporarily deployed
to
acr-shared-env
GitHub Actions
Inactive
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed!
|
hgo-ds
deleted the
fix/DO-4418-wrong-spelling-of-the-column-catenax_site_id-in-the-table-assets_as_planned
branch
hgo-ds
added a commit
that referenced
this pull request
Nov 29, 2023
… assets as planned (#63) fix:DO-4418:rename all properties to catenaXSiteId Because the existing possibilities of different spellings of the catenaXSiteId attribute cannot be resolved with certainty and the uncertainty of a change remains, all relevant places are implemented in the TRX regardless of the spelling.
hgo-ds
added a commit
that referenced
this pull request
Dec 4, 2023
… assets as planned (#63) fix:DO-4418:rename all properties to catenaXSiteId Because the existing possibilities of different spellings of the catenaXSiteId attribute cannot be resolved with certainty and the uncertainty of a change remains, all relevant places are implemented in the TRX regardless of the spelling.
hgo-ds
added a commit
that referenced
this pull request
Jan 2, 2024
… assets as planned (#63) fix:DO-4418:rename all properties to catenaXSiteId Because the existing possibilities of different spellings of the catenaXSiteId attribute cannot be resolved with certainty and the uncertainty of a change remains, all relevant places are implemented in the TRX regardless of the spelling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:DO-4418:rename all properties to catenaXSiteId
Because the existing possibilities of different spellings of the catenaXSiteId attribute cannot be resolved with certainty, and the uncertainty of a change remains, all relevant places are implemented in the TRX regardless of the spelling.
fix:DO-4418:Local variables should not shadow class fields
Further information provided here: eclipse-tractusx/sldt-semantic-models#470