Skip to content

Commit

Permalink
chore(sonar):[DO-1264] Enable sonar for frontend
Browse files Browse the repository at this point in the history
  • Loading branch information
ds-jkreutzfeld committed Oct 25, 2023
1 parent 3b64c13 commit b2e7f88
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 12 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/sonar-scan-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ name: "[FE][SECURITY] Sonar"

on:
push:
branches: [ main ]
branches:
- main
- dev
workflow_dispatch:
schedule:
- cron: "0 0 * * *"
Expand Down
21 changes: 10 additions & 11 deletions .github/workflows/unit-test_frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,13 @@ jobs:
- name: Run yarn test:ci
run: CHROMIUM_BIN=$(which chrome) yarn test:ci # will run `test:ci` command

# Currently disabled, as we do not have a SonarQube instance yet.
# - name: Run SonarCloud check
# uses: SonarSource/sonarcloud-github-action@master
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN_FRONTEND }}
# with:
# projectBaseDir: frontend
# args: >
# -Dsonar.organization=${{ vars.SONAR_ORGANIZATION }}
# -Dsonar.projectKey=${{ vars.SONAR_PROJECT_KEY_FRONTEND }}
- name: Run SonarCloud check
uses: SonarSource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN_FRONTEND }}
with:
projectBaseDir: frontend
args: >
-Dsonar.organization=${{ vars.SONAR_ORGANIZATION }}
-Dsonar.projectKey=${{ vars.SONAR_PROJECT_KEY_FRONTEND }}

0 comments on commit b2e7f88

Please sign in to comment.