Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

[DO-1257] Implement Quality alerts page designs #22

Merged
merged 8 commits into from
Oct 31, 2023
Merged

[DO-1257] Implement Quality alerts page designs #22

merged 8 commits into from
Oct 31, 2023
+269 −216

Conversation

viannbreslerAccso
Copy link

Implementation of the quality alerts page figma designs

@viannbreslerAccso viannbreslerAccso self-assigned this Oct 31, 2023
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 08:53 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Integration Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 45a1019.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Unit Test Results

225 tests   222 ✔️  26s ⏱️
  54 suites      3 💤
  54 files        0 ❌

Results for commit 45a1019.

♻️ This comment has been updated with latest results.

@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 09:20 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 09:23 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 09:27 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 10:28 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 10:32 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 10:34 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 10:39 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 10:39 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 10:44 — with GitHub Actions Inactive
JoelDietz
JoelDietz suggested changes Oct 31, 2023
View reviewed changes
Copy link

@JoelDietz JoelDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the height is fixed for the table scrollbar also breaks the dashboard tables. Please change the scrollbar settings.

frontend/src/app/modules/shared/components/table/table.component.scss Show resolved Hide resolved
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 11:13 — with GitHub Actions Inactive
@viannbreslerAccso viannbreslerAccso temporarily deployed to acr-shared-env October 31, 2023 11:17 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

95.8% 95.8% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@viannbreslerAccso viannbreslerAccso merged commit 7034f76 into dev Oct 31, 2023
18 checks passed
@viannbreslerAccso viannbreslerAccso deleted the feature/DO-1257_qualityAlertsPage branch October 31, 2023 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoelDietz JoelDietz JoelDietz approved these changes

Assignees

@viannbreslerAccso viannbreslerAccso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viannbreslerAccso @JoelDietz