testing map vs record. map preferable

CodySchrank · Feb 16, 2020 · 8c95623 · 8c95623
1 parent 852f6d2
commit 8c95623
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/Example/Example.csproj b/Example/Example.csproj
@@ -6,7 +6,7 @@
 
   <ItemGroup>
     <!-- <PackageReference Include="MTT" Version="0.6.4-*" PrivateAssets="All" /> -->
-    <PackageReference Include="MTT" Version="0.6.4" />
+    <PackageReference Include="MTT" Version="0.6.5" />
   </ItemGroup>
 
   <Target Name="ConvertMain" BeforeTargets="PrepareForBuild">

diff --git a/README.md b/README.md
@@ -84,7 +84,7 @@ export interface Vehicle extends Entity {
     make: string;
     model: string;
     mileage?: number;
-    options: Record<string, Units>;
+    options: Map<string, Units>;
     condition: VehicleState;
     parts: Part[];
     spareParts: Part[];
@@ -132,6 +132,8 @@ It correctly converts the following C# types to the equivalent typescript:
 * Optional
 * virtual
 * abstract
+* Dictionary
+* IDictionary
 
 ## Notes
 

diff --git a/Source/MTT/ConvertService.cs b/Source/MTT/ConvertService.cs
@@ -349,7 +349,7 @@ private void BreakDown()
                             LineObject obj = new LineObject()
                             {
                                 VariableName = varName,
-                                Type = "Record",
+                                Type = "Map",
                                 IsArray = false,
                                 IsOptional = isOptional,
                                 UserDefined = false,

diff --git a/Source/MTT/MTT.csproj b/Source/MTT/MTT.csproj
@@ -8,7 +8,7 @@
     <!-- Change the default location where NuGet will put the build output -->
     <BuildOutputTargetFolder>tasks</BuildOutputTargetFolder>
     <!-- set the version automatically -->
-    <VersionPrefix>0.6.4</VersionPrefix>
+    <VersionPrefix>0.6.5</VersionPrefix>
     <!-- 
         The suffix is required because nuget will only update if the package is newer, this tricks it. 
         note: 0.1.5 has precedence over 0.1.5-build123412341  

diff --git a/Source/MTTRunner.Tests/UnitTest.cs b/Source/MTTRunner.Tests/UnitTest.cs
@@ -98,10 +98,10 @@ public void OptionalPropertyExists() {
         }
 
         [Test]
-        public void CheckRecordExists() {
+        public void CheckMapExists() {
             string[] lines = System.IO.File.ReadAllLines(VehicleFile);
 
-            Assert.That(lines[12], Is.EqualTo("    options: Record<string, Units>;"));
+            Assert.That(lines[12], Is.EqualTo("    options: Map<string, Units>;"));
         }
 
         [Test]