Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Claude models and update dependencies #1302

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KennyDizi
Copy link
Contributor

@KennyDizi KennyDizi commented Oct 23, 2024

PR Type

Feature, Dependencies


Description

  • Added support for the vertex_ai/claude-3-5-sonnet-v2@20241022 model.
  • Added support for the anthropic/claude-3-5-sonnet-20241022 model.
  • Added support for the bedrock/anthropic.claude-3-5-sonnet-20241022-v2:0 model.
  • Updated anthropic library to version 0.37.1 to support new models.
  • Updated litellm library to version 1.50.2 to support new models.
  • Updated openai library to version 1.52.1.

Changes walkthrough

Relevant files
Feature
__init__.py
Add support for new Claude models                                               

pr_agent/algo/init.py

  • Added support for vertex_ai/claude-3-5-sonnet-v2@20241022 model.
  • Added support for anthropic/claude-3-5-sonnet-20241022 model.
  • +2/-0     
    Dependencies
    requirements.txt
    Update dependencies for model support                                       

    requirements.txt

  • Updated anthropic library to version 0.37.1.
  • Updated litellm library to version 1.50.2.
  • Updated openai library to version 1.52.1.
  • +3/-3     

    @KennyDizi KennyDizi changed the title Add support new anthropic claude-3-5-sonnet-20241022 model Add support for new Claude models and update dependencies Oct 23, 2024
    @KennyDizi
    Copy link
    Contributor Author

    💥 🌄 The PR description has been updated to align with the latest commit (a957554).

    @KennyDizi
    Copy link
    Contributor Author

    PR Analysis 🌍

    🌎 🌆 Here are some essential notes to support our PR review process:


    ⏰  Estimated effort to review 2, because the changes primarily involve adding new model support and updating dependencies, which are straightforward but require verification of compatibility and functionality.

    🥇  Score 85, because the PR effectively introduces new model support and updates dependencies, but lacks accompanying tests or documentation updates to ensure seamless integration.

    🧪  No relevant tests

    🔒  No security concerns identified

    🥳 Recommended focus areas for review

    Dependency Array
    Ensure that the newly added models 'vertex_ai/claude-3-5-sonnet-v2@20241022' and 'anthropic/claude-3-5-sonnet-20241022' are correctly integrated and that their token limits are appropriate.

    Dependency Update
    Verify that the updated dependencies (anthropic, litellm, and openai) are compatible with the existing codebase and do not introduce any breaking changes.

    @KennyDizi
    Copy link
    Contributor Author

    Tested on local, it works out.

    @mrT23
    Copy link
    Collaborator

    mrT23 commented Oct 23, 2024

    Thanks for the PR.

    We had some issues in the past with upgrading litellm. It's not always a seamless process (the last upgrade broke vllm integration)

    So, I want to test it for a day or two to be sure it's stable.

    @mrT23 mrT23 self-requested a review October 23, 2024 04:27
    @KennyDizi
    Copy link
    Contributor Author

    Thanks for the PR.

    We had some issues in the past with upgrading litellm. It's not always a seamless process (the last upgrade broke vllm integration)

    So, I want to test it for a day or two to be sure it's stable.

    That would be a suitable approach @mrT23. I'm keep testing on my end and will inform here if there is any issue.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants