Update Scopes instead of creating new ones if code is the same #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:CodiTramuntana/decidim-erc-crm_authenticable into refactor/update_scopes_when_code_is_the_same
tramuntanal
commented
Jan 12, 2022
laurajaime
force-pushed
the
refactor/update_scopes_when_code_is_the_same
branch
from
153f948 to
b6a3378
Compare
laurajaime
force-pushed
the
refactor/update_scopes_when_code_is_the_same
branch
from
b6a3378 to
dbaa3bd
Compare
tramuntanal
commented
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When updating scopes from yaml files if the code was the same but the name changed a new scope was created.
This PR resolves this situation and simply updates the Scope instead of resulting in two scopes with the same code and different names.