-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: look beyond first page of repo workflows #199
Conversation
Thanks for submitting this PR! Octokit actually provides a way to iterate over pages, we should probably adopt that method, an example is here: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 99.24% 99.31% +0.06%
==========================================
Files 3 3
Lines 399 435 +36
Branches 50 53 +3
==========================================
+ Hits 396 432 +36
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Great stuff! I wasn't aware of it. I'll quickly make the change. |
2c13b69
to
b3c4c42
Compare
Tests failing, the tests can be tricky, if you're happy to wait I can try address them on Friday or you can see how I handled testing against this in the knip-reporter repository and update the tests |
b3c4c42
to
9bf5558
Compare
Should be good now. There was also an issue with the token so I assumed it's because I'm the one who pushed the commit and I don't have the right access. I didn't push the update on the bundle this time. Feel free to take it from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your work on this, hugely appreciated
Ah I see, it rejected when I did it originally, fixed now! Thanks for pointing that out @pmrotule |
Closes #198
I hope you'll like my solution! I tested it already and it fixed the issue in our case where the workflow was found in the second page of results.