Fix harsh noise by only synthesizing samples while playing #1330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1298
Proposed changes
There was a race condition between the audio workers and the main synthesizer components when the playback finished. The sequence was roughly:
We fix this problem by checking on the synthesizer side whether we are currently playing and do not synthesize any samples. This prevents the sequence above by avoiding step 6.
Checklist
Further details