Ensure we do not signal the UI facade for empty partials #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1090
Proposed changes
ICanvas used to provide some results when render finished but not it doesn't. Due to that the onRenderFinished signals an empty render result to the UI facade to be displayed. The problem is that the new placeholder system does not clear placeholders to get a smoother UI: It is better to keep an old render result before the new one becomes available.
The problem is if the placeholder content has a 0 width and height. We would need to clean the placeholder from its old content because it will never become visible. To avoid implementing this code in every UI facade we simply not signal empty results to the UI facade anymore which will ensure placeholders are only filled with proper content or are removed.
Checklist
Further details