This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Bugfix/1276 export email dojo session #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 31, 2019 17:25
Code is horrible, but the email export was never implemented. This should be migrated to the new user service instead
ArayB
added a commit
that referenced
this pull request
Feb 13, 2020
Revert "Merge pull request #206 from Wardormeur/bugfix/1276-export-em…
|
Hey @ArayB, what happened? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we expose the parent email and phone during export
This is a first attempt at solving one of the scenarios in CoderDojo/community-platform#1276
This is a bugfix and I'm aware of the code quality. This should be moved to the new service, the code is properly bad (duplicate rows, unecessary o(2n) and such) and untested. However, it's up to your PM to organize where you wish to go with event management.
Also, happy new year :)