Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing translations #2413

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: missing translations #2413

merged 1 commit into from
Oct 29, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 29, 2024 •
edited
Loading

Closes https://github.com/Codeinwp/otter-internals/issues/232

Summary

  • The conditions help labels did not have the text domain like other strings

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 29, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 29, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.41 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 390 B (0.02%)
CSS 100.89 KB 100.89 KB 0 B (0.00%)
Dashboard 198.45 KB 198.45 KB 0 B (0.00%)
Onboarding 161.1 KB 161.1 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 423.27 KB 423.65 KB 390 B (0.09%)

@pirate-bot
Copy link
Contributor

Plugin build for ee4b3a3 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 239.8, firstPaint: 508.8, domContentLoaded: 1547, loaded: 1547.85, firstContentfulPaint: 3449.4, firstBlock: 7763.45, type: 13.24, minType: 11.43, maxType: 20.12, typeContainer: 9.42, minTypeContainer: 7.16, maxTypeContainer: 11.02, focus: 32.9, minFocus: 28.1, maxFocus: 44.85, inserterOpen: 23.73, minInserterOpen: 21.45, maxInserterOpen: 26.16, inserterSearch: 0.9, minInserterSearch: 0.78, maxInserterSearch: 1.06, inserterHover: 3.32, minInserterHover: 2.57, maxInserterHover: 4.51, listViewOpen: 143.97, minListViewOpen: 130.57, maxListViewOpen: 155.04

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit e196504 into development Oct 29, 2024
14 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the js/missing-translations branch October 29, 2024 14:56
@HardeepAsrani HardeepAsrani removed their request for review October 29, 2024 17:12
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soare-Robert-Daniel @pirate-bot