Development #1975
Merged
Development #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useSettings hook repeated calls to settings API after a recent version, probably after AI Content creator as that hooks to function to each block. After trying various methods, I settled on this one as it seems to work with all the current usage of useSettings that we have in Otter. I also tried to use a better implementation but those seem to not always work with the various use cases that we have with Otter. (as in using the Data Store for saving/retrieving the data) In the future, I'd avoid using useSettings in plugins as now Gutenebrg has built-in methods to use Settings API from the store, and as we work on different parts of Otter, we can try to remove the existing usage of useSettings.
fix: otter making repeated api calls
Bundle Size Diff
|
|
Plugin build for 25efcd0 is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 204.45, firstPaint: 597.55, domContentLoaded: 1727.35, loaded: 1729.5, firstContentfulPaint: 10946, firstBlock: 18279.5, type: 43.6, minType: 40.99, maxType: 46.62, typeContainer: 13.89, minTypeContainer: 12.01, maxTypeContainer: 16.82, focus: 65.43, minFocus: 58.17, maxFocus: 74.59, inserterOpen: 27.79, minInserterOpen: 23.73, maxInserterOpen: 33.06, inserterSearch: 8.79, minInserterSearch: 8.04, maxInserterSearch: 10.49, inserterHover: 41.13, minInserterHover: 36.92, maxInserterHover: 45.4, listViewOpen: 159.99, minListViewOpen: 137.95, maxListViewOpen: 174.77 |
|
@HardeepAsrani Tested and the Patterns and OpenAI API work fine 👍 |
|
@irinelenache Thank you, I've updated it. Can you try again? Thank you! Make sure to also test non-Stripe part again to confirm the changes didn't cause anything already tested from working. I tested on my side but having a second pair of eyes helps. |
|
@HardeepAsrani Tested and everything's fine now 🚀 |
|
🎉 This PR is included in version 2.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1973