Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #1953

Merged
merged 233 commits into from
Nov 16, 2023
Merged

Development #1953

merged 233 commits into from
Nov 16, 2023

Conversation

HardeepAsrani and others added 13 commits November 15, 2023 01:18
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.40 to 1.10.41.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.10.40...1.10.41)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [php-stubs/woocommerce-stubs](https://github.com/php-stubs/woocommerce-stubs) from 8.2.0 to 8.2.2.
- [Commits](php-stubs/woocommerce-stubs@v8.2.0...v8.2.2)

---
updated-dependencies:
- dependency-name: php-stubs/woocommerce-stubs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 13.1.0 to 13.3.0.
- [Release notes](https://github.com/stripe/stripe-php/releases)
- [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md)
- [Commits](stripe/stripe-php@v13.1.0...v13.3.0)

---
updated-dependencies:
- dependency-name: stripe/stripe-php
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases)
- [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md)
- [Commits](Codeinwp/themeisle-sdk@v3.3.7...v3.3.8)

---
updated-dependencies:
- dependency-name: codeinwp/themeisle-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…t/codeinwp/themeisle-sdk-3.3.8

chore(deps): bump codeinwp/themeisle-sdk from 3.3.7 to 3.3.8
…t/phpstan/phpstan-1.10.41

chore(deps-dev): bump phpstan/phpstan from 1.10.40 to 1.10.41
…t/php-stubs/woocommerce-stubs-8.2.2

chore(deps-dev): bump php-stubs/woocommerce-stubs from 8.2.0 to 8.2.2
…t/stripe/stripe-php-13.3.0

chore(deps): bump stripe/stripe-php from 13.1.0 to 13.3.0
@HardeepAsrani HardeepAsrani marked this pull request as ready for review November 14, 2023 21:38
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 14, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 275.01 KB 284.62 KB 9.62 KB (3.50%)
Blocks 1.47 MB 1.5 MB 30.11 KB (2.00%)
CSS 89.3 KB 91.71 KB 2.41 KB (2.70%)
Dashboard 132.27 KB 176.79 KB 44.52 KB (33.66%)
Export Import 87.21 KB 89.53 KB 2.32 KB (2.66%)
Pro 346.54 KB 354.07 KB 7.53 KB (2.17%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 14, 2023

Plugin build for c5b9afa is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 14, 2023

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 200.25, firstPaint: 571.75, domContentLoaded: 1673.65, loaded: 1675.7, firstContentfulPaint: 9921.1, firstBlock: 19433.4, type: 51.08, minType: 42.08, maxType: 62.97, typeContainer: 13.06, minTypeContainer: 11.02, maxTypeContainer: 20.61, focus: 74.5, minFocus: 63.94, maxFocus: 92.45, inserterOpen: 31.1, minInserterOpen: 23.5, maxInserterOpen: 39.1, inserterSearch: 9.95, minInserterSearch: 8.83, maxInserterSearch: 13.05, inserterHover: 42.48, minInserterHover: 37.08, maxInserterHover: 53.37, listViewOpen: 193.36, minListViewOpen: 171.78, maxListViewOpen: 207.43

@irinelenache
Copy link
Contributor

irinelenache commented Nov 15, 2023

@HardeepAsrani Tested the release builds and here is what i found:

@HardeepAsrani
Copy link
Member Author

Thank you @irinelenache, I've fixed the first three. The last one is bit tricky so we can leave it for now. For the 4th one, I'm not able to reproduce it so would it be possible for you to give step by step instructions on how we can reproduce it?

@irinelenache
Copy link
Contributor

@HardeepAsrani The marked issues are fixed now, thank you 🚀

This is how the AI generated patterns look using 2024 theme (before inserting) https://vertis.d.pr/i/LIuz3I

^ The issue happens because the container width in the editor is smaller using Twenty Twenty-Four, and some generated patterns with 4 columns look bad https://vertis.d.pr/i/FPtCbO https://vertis.d.pr/i/WJnLQQ (I'm using 14 inch macbook pro and Chrome)

@HardeepAsrani
Copy link
Member Author

@irinelenache My bad. I meant the 4th one we can let go for now. I'm not able to reproduce the 5th one. How do I do that?

dependabot bot and others added 2 commits November 16, 2023 15:29
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.8 to 3.3.9.
- [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases)
- [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md)
- [Commits](Codeinwp/themeisle-sdk@v3.3.8...v3.3.9)

---
updated-dependencies:
- dependency-name: codeinwp/themeisle-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…t/codeinwp/themeisle-sdk-3.3.9

chore(deps): bump codeinwp/themeisle-sdk from 3.3.8 to 3.3.9
@HardeepAsrani HardeepAsrani merged commit 1f6d787 into master Nov 16, 2023
12 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants