-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #1953
Development #1953
Conversation
HardeepAsrani
commented
Nov 2, 2023
•
edited
Loading
edited
- Identify and expand Unit testing #1623
- Add option to disable email notifications if user has enabled subscription #1290
- Add Bottom Margin option for the Advanced Heading #1490
- Investigate Maps in Neve Sidebar #1931
- Add option to hide a block depending on the device #1800
- CSS calc for Live Search do not work in Popup #1930
- RankMath not working with latest Otter #1955
- Form throwing error even if the data is properly sent #1933
- Custom Delay/Speed, Animation Offset & Hover controls for Blocks Animation #1548
- Pagination in Posts Block #1046
- Add option to export the form submissions #1671
- https://github.com/Codeinwp/otter-internals/issues/99
- Add option to add default values to form fields #1908
- https://github.com/Codeinwp/otter-internals/issues/90
- https://github.com/Codeinwp/otter-internals/issues/106
- Migrate performance test to Playwright #1884
- Count animation - delay and speed settings don't work #1960
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.40 to 1.10.41. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.40...1.10.41) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [php-stubs/woocommerce-stubs](https://github.com/php-stubs/woocommerce-stubs) from 8.2.0 to 8.2.2. - [Commits](php-stubs/woocommerce-stubs@v8.2.0...v8.2.2) --- updated-dependencies: - dependency-name: php-stubs/woocommerce-stubs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 13.1.0 to 13.3.0. - [Release notes](https://github.com/stripe/stripe-php/releases) - [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-php@v13.1.0...v13.3.0) --- updated-dependencies: - dependency-name: stripe/stripe-php dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases) - [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md) - [Commits](Codeinwp/themeisle-sdk@v3.3.7...v3.3.8) --- updated-dependencies: - dependency-name: codeinwp/themeisle-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…t/codeinwp/themeisle-sdk-3.3.8 chore(deps): bump codeinwp/themeisle-sdk from 3.3.7 to 3.3.8
…t/phpstan/phpstan-1.10.41 chore(deps-dev): bump phpstan/phpstan from 1.10.40 to 1.10.41
…t/php-stubs/woocommerce-stubs-8.2.2 chore(deps-dev): bump php-stubs/woocommerce-stubs from 8.2.0 to 8.2.2
…t/stripe/stripe-php-13.3.0 chore(deps): bump stripe/stripe-php from 13.1.0 to 13.3.0
[DEV] Migrate the performance test
Bundle Size Diff
|
Plugin build for c5b9afa is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 200.25, firstPaint: 571.75, domContentLoaded: 1673.65, loaded: 1675.7, firstContentfulPaint: 9921.1, firstBlock: 19433.4, type: 51.08, minType: 42.08, maxType: 62.97, typeContainer: 13.06, minTypeContainer: 11.02, maxTypeContainer: 20.61, focus: 74.5, minFocus: 63.94, maxFocus: 92.45, inserterOpen: 31.1, minInserterOpen: 23.5, maxInserterOpen: 39.1, inserterSearch: 9.95, minInserterSearch: 8.83, maxInserterSearch: 13.05, inserterHover: 42.48, minInserterHover: 37.08, maxInserterHover: 53.37, listViewOpen: 193.36, minListViewOpen: 171.78, maxListViewOpen: 207.43 |
@HardeepAsrani Tested the release builds and here is what i found:
|
Thank you @irinelenache, I've fixed the first three. The last one is bit tricky so we can leave it for now. For the 4th one, I'm not able to reproduce it so would it be possible for you to give step by step instructions on how we can reproduce it? |
@HardeepAsrani The marked issues are fixed now, thank you 🚀
^ The issue happens because the container width in the editor is smaller using Twenty Twenty-Four, and some generated patterns with 4 columns look bad https://vertis.d.pr/i/FPtCbO https://vertis.d.pr/i/WJnLQQ (I'm using 14 inch macbook pro and Chrome) |
@irinelenache My bad. I meant the 4th one we can let go for now. I'm not able to reproduce the 5th one. How do I do that? |
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.8 to 3.3.9. - [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases) - [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md) - [Commits](Codeinwp/themeisle-sdk@v3.3.8...v3.3.9) --- updated-dependencies: - dependency-name: codeinwp/themeisle-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…t/codeinwp/themeisle-sdk-3.3.9 chore(deps): bump codeinwp/themeisle-sdk from 3.3.8 to 3.3.9
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |