-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not ignore CURSOR color during typiing anim #1873
Conversation
Bundle Size Diff
|
Plugin build for 41d6615 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 69.19, 2 - 72.01, 3 - 67.15, 4 - 85.37, 5 - 80.63, 6 - 80.71, 7 - 124.98, 8 - 67.54, 9 - 67.59, 10 - 88.51, 11 - 90.71, 12 - 73.43, 13 - 76.48, 15 - 62.71, 16 - 90.00, 18 - 95.49" |
@Soare-Robert-Daniel I tried to test on multiple instances but the issue still happens for me https://vertis.d.pr/v/1WGnUu You can check here:
|
@irinelenache, my mistake here. I lived with the impression that the problem was with the text 🙈 |
@Soare-Robert-Daniel Tested again and now the issue is fixed ✔️ |
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1717
Summary
Now, the typing animation will respect the text color.
Screenshots
2023-09-25_13-26-04.mp4
Test instructions
Sample
Checklist before the final review