Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore CURSOR color during typiing anim #1873

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 19, 2023

Closes #1717

Summary

Now, the typing animation will respect the text color.

Screenshots

2023-09-25_13-26-04.mp4

Test instructions

  1. Create a paragraph and set a color.
  2. Add typing animation.
  3. See if it keeps the colors.

Sample

<!-- wp:paragraph {"textColor":"vivid-red","className":"o-typing-delay-500ms"} -->
<p class="o-typing-delay-500ms has-vivid-red-color has-text-color">Placerat habitasse commodo ante hac erat diam vehicula in porttitor. Ridiculus facilisis cursus inceptos orci dis faucibus neque justo curae. Mattis velit et accumsan sapien justo vivamus si. Netus hac fames aliquam ullamcorper convallis est habitasse letius molestie phasellus dui. Elit per adipiscing sodales nascetur est turpis vel curabitur. <o-anim-typing>Sapien quam class vel luctus a sagittis ad pellentesque. Viverra consectetur montes rhoncus inceptos cursus arcu.</o-anim-typing> Sodales etiam iaculis taciti augue ipsum montes placerat tristique per aliquam. Eget pede molestie placerat hac nulla conubia class habitasse maximus sit. Convallis molestie vitae morbi fames facilisi tempor.</p>
<!-- /wp:paragraph -->

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 19, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Sep 19, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 19, 2023 11:22
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 19, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 274.83 KB 274.81 KB -23 B (-0.01%)
Blocks 1.47 MB 1.47 MB 0 B (0.00%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 129.72 KB 129.72 KB 0 B (0.00%)
Export Import 87.19 KB 87.19 KB 0 B (0.00%)
Pro 346.75 KB 346.75 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 19, 2023

Plugin build for 41d6615 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 77.21 16.04 73.43 15.79 (60ms) 57.89 (80ms)
Values above 60ms "0 - 69.19, 2 - 72.01, 3 - 67.15, 4 - 85.37, 5 - 80.63, 6 - 80.71, 7 - 124.98, 8 - 67.54, 9 - 67.59, 10 - 88.51, 11 - 90.71, 12 - 73.43, 13 - 76.48, 15 - 62.71, 16 - 90.00, 18 - 95.49"

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel I tried to test on multiple instances but the issue still happens for me https://vertis.d.pr/v/1WGnUu

You can check here:

URL: https://otter-stuff.vertisite.cloud/test
Username: kikevepiwu4475
Password: nAfE6HGJrILlpUc3wOeu

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 25, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Do not ignore text color during typiing anim Do not ignore CURSOR color during typiing anim Sep 25, 2023
@Soare-Robert-Daniel
Copy link
Contributor Author

@irinelenache, my mistake here. I lived with the impression that the problem was with the text 🙈

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested again and now the issue is fixed ✔️

@HardeepAsrani HardeepAsrani merged commit 9788022 into development Sep 25, 2023
12 of 14 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/typing-color branch September 25, 2023 13:22
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing animation cursor color
4 participants