Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Live Search deps via WordPress Action Hook #1872

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 19, 2023

Closes #91

Summary

Wrap the live-search deps with a wp action named: otter_load_live_search_deps

Docs

If you want to load Live Search functionality in your custom theme or 3-rd party plugin. Use the wordpress action otter_load_live_search_deps.

Example:

do_action( 'otter_load_live_search_deps' );

ℹ️ This feature can only be used by Otter Pro users.


Test instructions

This is a dev-only change. The Libe Search should work as expected.


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 19, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 19, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 19, 2023 09:12
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title chore: wrap live-search deps with an action Load Live Search deps via WordPress Action Hook Sep 19, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 19, 2023
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 274.83 KB 274.83 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 0 B (0.00%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 127.66 KB 127.66 KB 0 B (0.00%)
Export Import 87.19 KB 87.19 KB 0 B (0.00%)
Pro 346.73 KB 346.73 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 1c9a6b3 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 77.41 17.23 73.13 10.53 (60ms) 63.16 (80ms)
Values above 60ms "0 - 60.11, 2 - 87.87, 3 - 73.13, 4 - 71.61, 5 - 68.52, 6 - 87.54, 7 - 95.29, 8 - 72.70, 9 - 71.53, 10 - 73.14, 11 - 113.26, 12 - 86.37, 13 - 75.45, 14 - 83.59, 15 - 60.53, 16 - 118.23, 18 - 61.57"

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and everything's fine here 🚀

@HardeepAsrani HardeepAsrani merged commit 92f1ba8 into development Sep 25, 2023
33 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/live-search-hook branch September 25, 2023 13:23
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants