-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Live Search deps via WordPress Action Hook #1872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Sep 19, 2023
Soare-Robert-Daniel
changed the title
chore: wrap live-search deps with an action
Load Live Search deps via WordPress Action Hook
Sep 19, 2023
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Sep 19, 2023
Bundle Size Diff
|
Plugin build for 1c9a6b3 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 60.11, 2 - 87.87, 3 - 73.13, 4 - 71.61, 5 - 68.52, 6 - 87.54, 7 - 95.29, 8 - 72.70, 9 - 71.53, 10 - 73.14, 11 - 113.26, 12 - 86.37, 13 - 75.45, 14 - 83.59, 15 - 60.53, 16 - 118.23, 18 - 61.57" |
HardeepAsrani
approved these changes
Sep 19, 2023
@Soare-Robert-Daniel Tested and everything's fine here 🚀 |
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Summary
Wrap the live-search deps with a wp action named:
otter_load_live_search_deps
Docs
If you want to load Live Search functionality in your custom theme or 3-rd party plugin. Use the wordpress action
otter_load_live_search_deps
.Example:
ℹ️ This feature can only be used by Otter Pro users.
Test instructions
This is a dev-only change. The Libe Search should work as expected.
Checklist before the final review