Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tabs header editable #1869

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Make tabs header editable #1869

merged 2 commits into from
Sep 25, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 15, 2023 •
edited
Loading

Closes #.

Summary

Tabs headers for desktop/tablet are now editable.

Screenshots

2023-09-15_14-32-37.mp4

Test instructions

  1. Make a Tabs block.
  2. Try to edit the content of the header.

⚠️ New lines are not allowed. If you add a new line, the next you type, it will be removed.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 15, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 15, 2023 11:54
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.87 KB 270.87 KB 0 B (0.00%)
Blocks 1.42 MB 1.42 MB 262 B (0.02%)
CSS 85.34 KB 85.34 KB 0 B (0.00%)
Dashboard 122.55 KB 122.55 KB 0 B (0.00%)
Export Import 83.23 KB 83.23 KB 0 B (0.00%)
Pro 303.4 KB 303.4 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for d287a24 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 68.57 4.98 68.02 5.26 (60ms) 94.74 (80ms)
Values above 60ms "0 - 69.76, 1 - 65.27, 3 - 63.29, 4 - 77.47, 5 - 64.38, 6 - 63.48, 7 - 68.02, 8 - 69.88, 9 - 67.53, 10 - 70.16, 11 - 70.33, 12 - 72.63, 13 - 70.59, 14 - 71.23, 15 - 64.74, 16 - 65.09, 17 - 81.48, 18 - 67.68"

@rodica-andronache
Copy link

@Soare-Robert-Daniel everything's working well 👍

@HardeepAsrani HardeepAsrani merged commit 3a1754a into development Sep 25, 2023
22 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/tabs-tab-title branch September 25, 2023 08:28
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Soare-Robert-Daniel @pirate-bot @rodica-andronache @HardeepAsrani