-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary deps when using widgets #1867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Sep 14, 2023
Soare-Robert-Daniel
changed the title
fix: improve widget asset loading
Remove unnecessary deps when using widgets
Sep 14, 2023
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Sep 14, 2023
Plugin build for e19da4b is ready 🛎️!
|
Bundle Size Diff
|
E2E SummaryTyping
Values above 60ms"0 - 62.33, 1 - 62.51, 2 - 62.93, 4 - 64.30, 5 - 67.96, 6 - 74.20, 7 - 66.45, 8 - 64.13, 9 - 65.32, 10 - 70.20, 11 - 69.16, 12 - 63.81, 13 - 68.60, 14 - 64.38, 15 - 70.38, 16 - 67.83, 17 - 63.06, 18 - 69.97" |
HardeepAsrani
approved these changes
Sep 14, 2023
@Soare-Robert-Daniel everything's working well 👍 |
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1665
Summary
Using
'dynamic_sidebar_params'
we can identify the used widgets in the page. The great changes is that we need to run the assets loading inwp_footer
since that filter will not run during'enqueue_block_assets'
.Screenshots
2023-09-14_10-49-13.mp4
Test instructions
ℹ️ Use a classic theme like Neve.
leaflet.js
and is not present in page, then that script should be loaded.Checklist before the final review