Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color section dropdown alignment selector #1826

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 23, 2023

Closes #1711

Summary

Updated the Section Color Dropdown Component selector regarding the alignment fix in Inspector for the Dropdown component.

Not the selector targets 5.x and 6.0 WP versions. ^6.1 will not be affected.

Screenshots

Before in WP 6.3

After in WP 6.3

image


Test instructions

⚠️ We need to test backward compatibility with 5.9, 6.0, 6.1, 6.1

  1. Insert a Section Block
  2. Go to its color picker in Background & Content on the Style tab, and when pressing the change color, the Popover will be beside the Inspector. Not too further and not inside.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

Before WP6.1, the Dropdown need an offset so it can be displayed correctly in Inspector. At the beggining, the selector was accounting only for 6.1 as exception.

Now, the selector target any 5.X and 6.0. ^6.1 will not be affected.
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 23, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 23, 2023 10:11
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 23, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.78 KB 270.78 KB 0 B (0.00%)
Blocks 1.42 MB 1.42 MB 54 B (0.00%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 303.27 KB 303.33 KB 54 B (0.02%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 23, 2023

Plugin build for 642b743 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 23, 2023

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 55.44 3.78 56.07 89.47 (60ms) 100 (80ms)
Values above 60ms "8 - 62.54, 10 - 60.74"

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue isn't fixed for the Background and Background overlay colors https://vertis.d.pr/v/kIO9c2

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 24, 2023
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Checked again and everything's fine now 👍

@HardeepAsrani HardeepAsrani merged commit 32176c7 into development Aug 31, 2023
12 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/section-color-dropdown branch August 31, 2023 07:26
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual issue in Section's Background & Background Overlay Controls
4 participants