-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: color section dropdown alignment selector #1826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before WP6.1, the Dropdown need an offset so it can be displayed correctly in Inspector. At the beggining, the selector was accounting only for 6.1 as exception. Now, the selector target any 5.X and 6.0. ^6.1 will not be affected.
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Aug 23, 2023
Bundle Size Diff
|
Plugin build for 642b743 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"8 - 62.54, 10 - 60.74" |
HardeepAsrani
approved these changes
Aug 23, 2023
@Soare-Robert-Daniel Tested and the issue isn't fixed for the Background and Background overlay colors https://vertis.d.pr/v/kIO9c2 |
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Aug 24, 2023
@Soare-Robert-Daniel Checked again and everything's fine now 👍 |
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1711
Summary
Updated the Section Color Dropdown Component selector regarding the alignment fix in Inspector for the Dropdown component.
Not the selector targets 5.x and 6.0 WP versions. ^6.1 will not be affected.
Screenshots
Before in WP 6.3
After in WP 6.3
Test instructions
Checklist before the final review