Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AI showcase in Otter Onboarding Modal #1818

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Add AI showcase in Otter Onboarding Modal #1818

merged 8 commits into from
Aug 23, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 16, 2023 •
edited
Loading

Closes https://github.com/Codeinwp/otter-internals/issues/102

Summary

Add AI Showcase step in Otter Onboarding Modal.

Screenshots

2023-08-16.16-11-59.mp4

Test instructions

  1. Check if the AI Showcase part in present in Modal.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 16, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title feat: add ai showcase in modal Add AI showcase in Otter Onboarding Modal Aug 16, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 16, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 16, 2023 13:14
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 16, 2023 •
edited
Loading

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.78 KB 270.78 KB 0 B (0.00%)
Blocks 1.41 MB 1.42 MB 490 B (0.03%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 302.52 KB 302.52 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 16, 2023 •
edited
Loading

Plugin build for 5808e03 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 16, 2023 •
edited
Loading

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 61.11 3.62 60.31 42.11 (60ms) 100 (80ms)
Values above 60ms "0 - 69.65, 2 - 61.59, 4 - 65.41, 6 - 62.25, 7 - 63.90, 8 - 67.62, 11 - 60.10, 12 - 60.31, 13 - 60.94, 14 - 60.70, 16 - 64.88"

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 21, 2023
@HardeepAsrani HardeepAsrani changed the base branch from development to next August 21, 2023 23:41
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and everything's fine here 👍

@HardeepAsrani HardeepAsrani changed the base branch from next to feat/ai-content-toolbar August 23, 2023 04:00
@HardeepAsrani HardeepAsrani merged commit 46b83b7 into feat/ai-content-toolbar Aug 23, 2023
13 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/ai-onboarding branch August 23, 2023 04:00
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Soare-Robert-Daniel @pirate-bot @irinelenache @HardeepAsrani