Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing submit messages for Form #1817

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 16, 2023

Closes #1804

Summary

Added missing submit messages handlers.


Test instructions

  1. Create a Form and set custom submit messages for Succes and Error in block Inspector.
  2. Test the success message.
  3. Try to break the form to get the error message.

ℹ️ If you do not want to go through the process of installing the SMPT for mail. You can activate otter pro and use save in Database to test the success message, then switch to Email for error. (You will get an error if you do not have the SMPT set up)


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 16, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 16, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 16, 2023 11:08
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.78 KB 270.78 KB 0 B (0.00%)
Blocks 1.41 MB 1.41 MB 76 B (0.01%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 302.52 KB 302.52 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 7dc8e53 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 63.64 6.89 61.98 31.58 (60ms) 94.74 (80ms)
Values above 60ms "0 - 69.79, 3 - 63.00, 5 - 63.45, 7 - 83.62, 8 - 72.55, 9 - 61.98, 10 - 62.55, 13 - 61.11, 14 - 60.93, 15 - 69.42, 16 - 61.41, 17 - 68.43, 18 - 67.43"

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 16, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Aug 16, 2023 that may be closed by this pull request
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now 🚀

@HardeepAsrani HardeepAsrani merged commit 0adae93 into development Aug 21, 2023
@HardeepAsrani HardeepAsrani deleted the fix/form-contact branch August 21, 2023 23:41
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otter Contact Form Block "Submit Messages" Settings not Working Error message does not correspond
4 participants