Fix inspector header reset on transition between Desktop to Tablet/Mobile #1801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1752 .
Summary
I implemented a Global State Memory that keeps the data when the content editor is transformed to an
iFrame
during the Preview from Desktop to Tablet/Mobile.In the root window, we save global values that keep the state in a dictionary structure. Since the root window data is
readonly
when accessed by theiFrame
, we need to use the browser event system to transmit the change from theiFrame
viapostMessage
.ℹ️ Even if Gutenberg now has tabs for the Inspector. The Core Block has no mechanism for retention of state. Like Otter, they reset on the viewport change. Until they implement such a feature, we will use our solution.
Screenshots
2023-08-07.18-06-56.mp4
Test instructions
When changing the viewport, the state of the Inspector should be kept.
What to look for:
Checklist before the final review