fix typing animation not working, closes #1960

Codeinwp · Nov 14, 2023 · 53b2838 · 53b2838
1 parent 60129ef
commit 53b2838
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/animation/count/inline-controls.js b/src/animation/count/inline-controls.js
@@ -35,6 +35,10 @@ import { format as settings } from './index.js';
 
 import { updateAnimConfig } from '../editor.js';
 
+// Fitler out 'custom' value from delayList and speedList
+delayList.pop();
+speedList.pop();
+
 const InlineControls = ({
 	value,
 	contentRef
@@ -99,14 +103,14 @@ const InlineControls = ({
 				label={ __( 'Delay', 'otter-blocks' ) }
 				value={ countDelay || 'none' }
 				options={ delayList }
-				onChange={ value => updateAnimConfig( 'count', countDelay, value, () => setCountDelay( value ) ), attributes, setAttributes }
+				onChange={ value => updateAnimConfig( 'count', countDelay, value, () => setCountDelay( value ), attributes, setAttributes ) }
 			/>
 
 			<SelectControl
 				label={ __( 'Speed', 'otter-blocks' ) }
 				value={ countSpeed || 'none' }
 				options={ speedList }
-				onChange={ value => updateAnimConfig( 'count', countSpeed, value, () => setTypingSpeed( value ) ), attributes, setAttributes }
+				onChange={ value => updateAnimConfig( 'count', countSpeed, value, () => setCountSpeed( value ), attributes, setAttributes ) }
 			/>
 
 			{ applyFilters( 'otter.poweredBy', '' ) }

diff --git a/src/animation/typing/inline-controls.js b/src/animation/typing/inline-controls.js
@@ -35,6 +35,10 @@ import { format as settings } from './index.js';
 
 import { updateAnimConfig } from '../editor.js';
 
+// Fitler out 'custom' value from delayList and speedList
+delayList.pop();
+speedList.pop();
+
 const InlineControls = ({
 	value,
 	contentRef