Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InnerBrowser::getFormFor attempts to insert a submit button incorrectly #1381

Closed
zbateson opened this issue Sep 5, 2014 · 0 comments
Closed

InnerBrowser::getFormFor attempts to insert a submit button incorrectly #1381

zbateson opened this issue Sep 5, 2014 · 0 comments

Comments

@zbateson
Copy link
Member

zbateson commented Sep 5, 2014

getFormFor calls current() without first calling rewind(), which causes it to return null. The call to first() is a DomCrawler call. It does not set the pointer.
zbateson added a commit to zbateson/Codeception that referenced this issue Sep 5, 2014
@zbateson
Fix for InnerBrowser::submitForm with document-relative paths
30ad2fe 
Unit test and fix for forms with document-relative paths for action -
issue Codeception#1274

This fix relies on the fix for issue Codeception#1381 to pass all tests (that issue
causes another test to fail with a fatal error)
@zbateson zbateson mentioned this issue Sep 5, 2014
Closed
DavertMik added a commit that referenced this issue Sep 27, 2014
@DavertMik
Merge pull request #1382 from zbateson/getFormFor-current-fix
584abb2 
Fix for #1381 - fillField fails for a form without a submit button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavertMik @zbateson