Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy square #5740

Merged
merged 18 commits into from
Dec 20, 2024
Merged

Numpy square #5740

merged 18 commits into from
Dec 20, 2024

Conversation

cmaxreilly
Copy link
Contributor

Description

Added an entry for the numpy.square() function. Fixed some small formatting errors in a c file.

Issue Solved

#5701

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dakshdeepHERE dakshdeepHERE self-assigned this Dec 3, 2024
@dakshdeepHERE dakshdeepHERE added new entry New entry or entries numpy NumPy entries status: under review Issue or PR is currently being reviewed labels Dec 3, 2024
@dakshdeepHERE dakshdeepHERE linked an issue Dec 3, 2024 that may be closed by this pull request
[Term Entry] NumPy: .square() #5701
Closed
3 tasks
dakshdeepHERE
dakshdeepHERE requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments for you to work on. Also, remove the changes you made to the printf.md file; they are not required in this PR.

content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
content/numpy/concepts/math-methods/terms/square/square.md Outdated Show resolved Hide resolved
@cmaxreilly
Copy link
Contributor Author

@dakshdeepHERE, I believe that I have made all of the changes you requested. Please let me know if I have missed anything!

dakshdeepHERE
dakshdeepHERE approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing the changes, I have made few minor changes, and this looks good for a second review 🚀

@mamtawardhani mamtawardhani added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Dec 19, 2024
@mamtawardhani mamtawardhani self-assigned this Dec 19, 2024
mamtawardhani
mamtawardhani reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @cmaxreilly 😄

The entry looks good to be merged! 🚀

mamtawardhani
mamtawardhani approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @cmaxreilly 😄

The entry looks good to be merged! 🚀

@mamtawardhani mamtawardhani merged commit a36c38a into Codecademy:main Dec 20, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @cmaxreilly
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/numpy/math-methods/square

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

@mamtawardhani mamtawardhani mamtawardhani approved these changes

Assignees

@mamtawardhani mamtawardhani

@dakshdeepHERE dakshdeepHERE

Labels
new entry New entry or entries numpy NumPy entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] NumPy: .square()
4 participants
@cmaxreilly @CLAassistant @mamtawardhani @dakshdeepHERE