add error information for when sonatype fails #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The result after using my local install of this plugin is something like this... |
szpak
reviewed
Dec 23, 2016
| HttpResponseDecorator response = (HttpResponseDecorator)restClient.post(params) | ||
| log.warn("POST response data: ${response.data}") | ||
| try { | ||
| //TODO: Add better error handling (e.g. display error message received from server, not only 500 + not fail on 404 in 'text/html') |
There was a problem hiding this comment.
This comment is no longer valid after your changes :).
| HttpResponseDecorator resp = e.getResponse(); | ||
| String message = "${resp.statusLine.statusCode}:${resp.statusLine.reasonPhrase} body=${resp.data}" | ||
| log.error("POST response failed. ${message}") | ||
| throw new HttpResponseException(e.getStatusCode(), message) |
There was a problem hiding this comment.
We lose original stacktrace. Please include e as a cause.
| //TODO: Add better error handling (e.g. display error message received from server, not only 500 + not fail on 404 in 'text/html') | ||
| HttpResponseDecorator response = (HttpResponseDecorator)restClient.post(params) | ||
| log.warn("POST response data: ${response.data}") | ||
| } catch(groovyx.net.http.HttpResponseException e) { |
| //put all information there (status code, error str, body of response in case they put more error information there) | ||
|
|
||
| HttpResponseDecorator resp = e.getResponse(); | ||
| String message = "${resp.statusLine.statusCode}:${resp.statusLine.reasonPhrase} body=${resp.data}" |
There was a problem hiding this comment.
(two spaces) before body - one would be enough.
| String message = "${resp.statusLine.statusCode}:${resp.statusLine.reasonPhrase} body=${resp.data}" | ||
| log.error("POST response failed. ${message}") | ||
| throw new HttpResponseException(e.getStatusCode(), message) | ||
| } |
There was a problem hiding this comment.
Please reformat this code fragment in general. It seems your are using tabs instead of spaces.
There was a problem hiding this comment.
I created #33 to better handle that.
szpak
requested changes
Dec 23, 2016
|
And you can also squash those commits into one. |
|
@deanhiller Can you fix the things I mentioned in the code review to make this PR being merged? |
|
I reworked it your changes and merged them manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the info so e.getMessage() when used which is printed when using --stacktrace. Also, we log the same thing as well for those not using --stacktrace as this is a pretty important failure and one needs to know the issue that occurred from the remote end.