This repository has been archived by the owner on Oct 26, 2020. It is now read-only.
Zision week 9.2 #1038
Open
Zision week 9.2 #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrolfe
reviewed
Jul 18, 2020
|
|
||
| cartContains() { | ||
| // Use console.log() to output everything contained in your cart | ||
| console.log(`Your shopping cart has ${this.total} items : ${this.array} `); |
There was a problem hiding this comment.
To make the output easier to read you can do this instead:
${this.array.join(', ')}
evanrolfe
reviewed
Jul 18, 2020
|
|
||
| addItem(item) { | ||
| this.array.push(item); | ||
| this.total++; |
There was a problem hiding this comment.
This works, but the code would be better if you only had one instance variable this.array and instead got the total from a function i.e.
total() {
return this.array.length;
}This is better because you don't have to keep track of two variables, you only need one.
|
Nice work 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt Exercises for this week, Didn't try Last exercise. Please review.