This repository has been archived by the owner on Oct 26, 2020. It is now read-only.
Farhana week 9 #1035
Open
Farhana week 9 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedekind561
reviewed
Jul 12, 2020
| this.total = 0; | ||
| this.items = []; | ||
| } | ||
| addItem(item){ |
| this.balance = 100; | ||
| } | ||
|
|
||
| make_deposit(moneyIn){ |
There was a problem hiding this comment.
Good parameter naming here for moneyIn
| make_withdrawl(moneyOut){ | ||
| if(this.balance > 100){ | ||
| this.balance = this.balance - moneyOut; | ||
| } else { |
There was a problem hiding this comment.
Good check to see if you can make the withdrawal
| @@ -21,21 +21,60 @@ This means the order the songs are played in will be random, but each song will | |||
|
|
|||
| class MusicPlayer { | |||
| // Add your code here | |||
| constructor(){ | |||
| this.playlist = []; | |||
There was a problem hiding this comment.
Is it possible to have a single array like playList that stores in the information about the title and the artist ? Think of another data type you could use other than a string
| constructor(){ | ||
| this.playlist = []; | ||
| this.artists = []; | ||
| this.currentTrack = 0; |
There was a problem hiding this comment.
Good - currentTrack is clear to me
| } | ||
|
|
||
| skip(){ | ||
| this.currentTrack ++; |
| let temperatureDegree = document.querySelector(".temperature-degree"); | ||
| let locationTimezone = document.querySelector(".location-timezone"); | ||
| let iconEl = document.querySelector(".icon"); | ||
| let temperatureSection = document.querySelector(".temperature"); |
There was a problem hiding this comment.
Good job here - are there any parts of the code you need help with at the moment ?
There was a problem hiding this comment.
Or bits that you need explaining again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name:
Your City:
Your Slack Name:
Homework Details
Module:
Week: