This repository has been archived by the owner on Oct 26, 2020. It is now read-only.
Bashir week 7 #1011
Open
Bashir week 7 #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to follow previously sent common practice and instructions fixed some typos
Minor changes to make language consistent and simplify it where needed.
Dedekind561
reviewed
Jul 12, 2020
| @@ -89,12 +90,12 @@ function render() { | |||
| }); | |||
|
|
|||
| //add delete button to every row and render again | |||
| let delButton = document.createElement("button"); | |||
| let delBut = document.createElement("button"); | |||
| @@ -76,7 +77,7 @@ function render() { | |||
| changeBut.className = "btn btn-success"; | |||
| cell4.appendChild(changeBut); | |||
| let readStatus = ""; | |||
| if (myLibrary[i].check == false) { | |||
| if (myLibrary[i].check === true) { | |||
| ## 3. What should you do if you get stuck? | ||
|
|
||
| <!-- Write your answer here --> | ||
|
|
||
| Read the problem several times and write a pseudocode |
There was a problem hiding this comment.
Good - always try to really understand the problem you're trying to solve and then some pseudocode is good for making you think about the code you need to write
| @@ -54,7 +55,7 @@ function render() { | |||
| let table = document.getElementById("display"); | |||
| let rowsNumber = table.rows.length; | |||
| //delete old table | |||
| for (let n = rowsNumber - 1; n > 0; n-- { | |||
| for (let n = rowsNumber - 1; n > 0; n--) { | |||
| @@ -37,8 +37,9 @@ function submit() { | |||
| alert("Please fill all fields!"); | |||
| return false; | |||
| } else { | |||
| let book = new Book(title.value, title.value, pages.value, check.checked); | |||
| let book = new Book(title.value, author.value, pages.value, check.checked); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name:
Your City:
Your Slack Name:
Homework Details
Module:
Week: