-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6 | Rabia Avci | HTML-CSS | Week 1 #472
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Some good work here, you're doing very well but also issues I'm afraid. Here's what needs to change:
- The text and buttons over the big images are not in the same place as the images say
- All the text in the cards is orange, not just the headers
- There's far more padding/whitespace between the edge of the page and the content.
Please try to fix and If this doesn't make sense, let me know
Thanks for your review @Ara225! I studied flex layout and then decided to re-work on this task. Therefore I started from scratch and fixed all the issues. I will appreciate it if you can review it again. Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantic markup was added successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-The broken images were successfully added with the absolute path.
-The required colour in the CSS was corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The buttons were styled properly with a hover effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code was corrected by adding class to style.css, Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job by modifying the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transition and hover effects are working properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing and fixing positions are working well, but since you used Flexbox try to add a collapsible navbar.
-Thanks for your review, Anna. I've made all the changes to the lists above as you've asked. |
Looking really good! I think everything I metioned has been fixed well :) |
Use semantic markup
Fix the broken images
Style buttons
Add spacing
Hover effects