-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aida Zhukova | Sprint-1 - Module-Structuring-and-Testing-Data | SPRINT 1 #240
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some feedback
@@ -5,7 +5,10 @@ let lastName = "Johnson"; | |||
// Declare a variable called initials that stores the first character of each string. | |||
// This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | |||
|
|||
let initials = ``; | |||
let initials = `${firstName.charAt(0)} + ${middleName.charAt(0)} + ${lastName.charAt(0)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result is not as expected. Gives 'C + K + J' as opposed to 'CKJ'. Do you see any way to remedy this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
Sprint-1/1-key-exercises/3-paths.js
Outdated
@@ -17,7 +17,11 @@ console.log(`The base part of ${filePath} is ${base}`); | |||
// Create a variable to store the dir part of the filePath variable | |||
// Create a variable to store the ext part of the variable | |||
|
|||
const dir = ; | |||
const ext = ; | |||
const dir = filePath.slice(0, lastSlashIndex+1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look very carefully at all the characters contained within the 'dir' column, and not underneath the borders between columns. Is there any difference between what's shown there and the value of your 'dir' variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
Sprint-1/1-key-exercises/3-paths.js
Outdated
const ext = ; | ||
const dir = filePath.slice(0, lastSlashIndex+1); | ||
console.log(dir) | ||
const ext = base.slice(base.lastIndexOf(".") + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look very carefully at all the characters contained within the 'ext' column. Is there any difference between what's shown there and the value of your 'ext' variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
Sprint-1/2-mandatory-errors/3.js
Outdated
@@ -1,9 +1,15 @@ | |||
const cardNumber = 4533787178994213; | |||
const last4Digits = cardNumber.slice(-4); | |||
let text=cardNumber.toString() | |||
const last4Digits = text.slice(-4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, but perhaps the data type of last4Digits should match that of cardNumber.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
Sprint-1/2-mandatory-errors/4.js
Outdated
const $12HourClockTime = "20:53"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the values of these variables match what is to be expected, given their names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
|
||
// a)lines 4,5,10 | ||
// b)Missing (,) sign in line 5 in function call. | ||
// c) line 3 and 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 3 is blank
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
|
||
|
||
// 3-5. Method substring identifies length and Removes (p) element from the end of string. | ||
// 8.Method padStart identifies any symbols after 3 if they are. And change them to 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the purpose of the padStart function. Think about the meaning of the term 'padding' to help figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in abefa5f
Aida Zhukova | Module-Structuring-and-Testing-Data | Week2
Learners, PR Template
Self checklist
Changelist
I'm done with Sprint-1 in Module-Structuring-and-Testing-Data.
Questions
No questions.