West Midlands| Danial Bashirzadeh | Module-Data-Flows | Week2 | Debugging | book-library #134
Conversation
bashirzadehdanial
added
the
Needs Review
| @@ -54,7 +54,7 @@ function render() { | |||
| let table = document.getElementById("display"); | |||
| let rowsNumber = table.rows.length; | |||
| //delete old table | |||
| for (let n = rowsNumber - 1; n > 0; n-- { | |||
| for (let n = rowsNumber - 1; n > 0; n--) { | |||
There was a problem hiding this comment.
Can you think of a more efficient way to remove all rows (except the heading) in the table?
There was a problem hiding this comment.
A more efficient way to remove all rows except the heading is to clear the tbody directly.
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| delButton.id = i + 5; |
There was a problem hiding this comment.
- Do you think the value assigned to this
idattribute is unique? - Do you think there is a need to assign any id attribute to
delButton? - Do you think there is a need to assign any id attribute to
changeBut(at line 75)? - Can you think of a more consistent way to name the variables representing the two buttons?
There was a problem hiding this comment.
1- No, the id values aren't guaranteed to be unique.
2- No, id for delButton is unnecessary.
3- No, id for changeBut isn't needed.
4- More descriptive names like deleteButton and toggleReadButton.
| @@ -17,6 +17,8 @@ Take a look at the following code: | |||
|
|
|||
| Explain why line 5 and line 8 output different numbers. | |||
|
|
|||
| The variable at line 5 is global, so it returns 1, while the variable at line 8 is local to the function. Thus, when the function is called, it logs the x variable from its scope. | |||
There was a problem hiding this comment.
The variable at line 5 is definite not global.
I wonder how ChatGPT would answer this question.
There was a problem hiding this comment.
I provided the code to chatGPT and received "Line 5 logs 2, Line 8 logs 1", which I believe is wrong as the output logs 2 for both because the variable is updated.
There was a problem hiding this comment.
I meant line 1 is global, not line 5, it was my bad.
| @@ -35,6 +37,8 @@ console.log(y); | |||
|
|
|||
| What will be the output of this code. Explain your answer in 50 words or less. | |||
|
|
|||
| The output will be 10 and undefined, as the y variable is scoped within the function and can't be accessed globally. | |||
There was a problem hiding this comment.
Did you try executing the code to verify your answer?
The second statement is correct about y, but it does not explain why the first output is 10.
There was a problem hiding this comment.
Output is 10 because it accesses the global variable x.
| @@ -62,3 +66,5 @@ console.log(y); | |||
| ``` | |||
|
|
|||
| What will be the output of this code. Explain your answer in 50 words or less. | |||
|
|
|||
| The output will be 9 and {x: 10} because of the different ways the variables are passed. In f1, x is passed by value, so the function doesn't alter its original value. In f2, y is passed by reference, so changes within the function modify the original value of y. | |||
cjyuan
added
Reviewed
bashirzadehdanial
added
the
Complete
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.