West Midlands | Gabriel Deng | Module-Data-Groups | Week 2 - Book reading #131

gai93003 · 2025-01-09T23:21:04Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

…e variable name myLibrary. Also change the title.value to author.value

cjyuan

In terms of input validation,

Are all input properly checked?
Can .value be null?
What if a user enters only space characters in the "title" input field?
What if a users enters -1 or 3.1416 in the "pages" input field?

There are also some errors in index.html.

cjyuan · 2025-01-16T21:52:28Z

debugging/book-library/script.js

@@ -54,7 +54,7 @@ function render() {
  let table = document.getElementById("display");
  let rowsNumber = table.rows.length;
  //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- {
+  for (let n = rowsNumber - 1; n > 0; n--) {


Can you think of a more efficient way to remove all rows (except the heading) in the table?

I think the most efficient way is to set the innerHTML of the table to emtpy and then appendChild header. In this case the first row.

I have also implemented the checking of the input of spaces using the input.value.trim() and check if it is empty. If so, an alert will pop out. Similarly, the validation of the page input field is also implemented.

cjyuan · 2025-01-16T21:57:18Z

debugging/book-library/script.js

-    delBut.className = "btn btn-warning";
-    delBut.innerHTML = "Delete";
-    delBut.addEventListener("clicks", function () {
+    delButton.id = i + 5;


Do you think the value assigned to this id attribute is unique?

Do you think there is a need to assign any id attribute to delButton?

Do you think there is a need to assign any id attribute to changeBut (at line 75)?

Can you think of a more consistent naming convention for the variables representing the two buttons?

The assignment of the id in this case is not important because there is no where in the code where the button is being used in reference to the id. So i have deleted it to make the code more readable and as precise as possible.

cjyuan · 2025-01-16T21:58:58Z

debugging/code-reading/readme.md

@@ -62,3 +67,8 @@ console.log(y);
 ```

 What will be the output of this code. Explain your answer in 50 words or less.
+
+Ans: The output will be 9 and {x: 10}; This is due to the difference by which each of the 


cjyuan · 2025-01-16T22:01:40Z

debugging/code-reading/readme.md

@@ -35,6 +38,8 @@ console.log(y);

 What will be the output of this code. Explain your answer in 50 words or less.

+Ans: The output will be 10 and undefined. This is because the y variable is declared within the scope of the function and therefore cannot be globally accessed.


Did you try running the code to see what it produces?

The second statement does not explain why the first output is 10.

You are right, the output is indeed 10 and undefined. I try making some research and it turns out that it is because the function has no return value although y has been declared and assigned a value.

When I ran the script, the script threw an exception (because y is not declared). Just curious, did you not get an exception?

cjyuan · 2025-01-16T22:11:01Z

debugging/code-reading/readme.md

+Ans: The variable at line 5  is a globally declared as such it will return 1, while the variable at line 8 is a scope variable since is declared with the scope of the function.
+      Therefore, when the function is called it will console the x variable declared in its scope.
+


I am not sure what you meant. The x at line 5 is certainly not globally declared.
I wonder how ChatGPT would answer this question.

I misinterpreted how the scope works. I didn't take into account where the console logs where being called. The console inside the function will refer to the local variable x and vice-versa.

Made changes based on the reviews

gai93003 added 4 commits January 9, 2025 01:11

There was a missing parenthesis, i also change the mis-spelling of th…

06f3a34

…e variable name myLibrary. Also change the title.value to author.value

Made some changes on the code

10feedb

some more changes

f81b156

I attempted the challenges on this file.

a3e8186

gai93003 added the Needs Review Participant to add when requesting review label Jan 9, 2025

cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 16, 2025

cjyuan reviewed Jan 16, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 16, 2025

Update script.js

fb8b22f

Made changes based on the reviews

gai93003 added the Complete Participant to add when work is complete and review comments have been addressed label Jan 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

West Midlands | Gabriel Deng | Module-Data-Groups | Week 2 - Book reading #131

West Midlands | Gabriel Deng | Module-Data-Groups | Week 2 - Book reading #131

gai93003 commented Jan 9, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading

cjyuan Jan 16, 2025

gai93003 Jan 16, 2025

gai93003 Jan 16, 2025

cjyuan Jan 16, 2025

gai93003 Jan 16, 2025

cjyuan Jan 16, 2025

gai93003 Jan 16, 2025

cjyuan Jan 16, 2025

gai93003 Jan 16, 2025

cjyuan Jan 17, 2025

cjyuan Jan 16, 2025

gai93003 Jan 16, 2025

		@@ -35,6 +38,8 @@ console.log(y);

		What will be the output of this code. Explain your answer in 50 words or less.

		Ans: The output will be 10 and undefined. This is because the y variable is declared within the scope of the function and therefore cannot be globally accessed.

		Ans: The variable at line 5 is a globally declared as such it will return 1, while the variable at line 8 is a scope variable since is declared with the scope of the function.
		Therefore, when the function is called it will console the x variable declared in its scope.

West Midlands | Gabriel Deng | Module-Data-Groups | Week 2 - Book reading #131

Are you sure you want to change the base?

West Midlands | Gabriel Deng | Module-Data-Groups | Week 2 - Book reading #131

Conversation

gai93003 commented Jan 9, 2025 • edited Loading

Learners, PR Template

Changelist

Questions

cjyuan left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gai93003 commented Jan 9, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading