Replace Sleep with While Loop in WorkerPoolTest #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLtDave
force-pushed
the
WorkerPoolTest
branch
from
ff56cb6
to
77e0268
Compare
One should use proper data structures to maintain a list of listeners. Fixes eclipse-platform#613
Deleted useless test class Good.java because the test is trivial. Furthermore the package org.eclipse.tips.tests was also deleted because it is empty now. Contributes to eclipse-platform#525.
Summary: Replaced a 5-second sleep used to wait for worker threads to become idle in the WorkerPoolTest with a while loop. This change includes a timeout of 5 seconds to check when there are fewer than 50 workers, making the test more responsive and reliable. Changes: - Removed the `Thread.sleep(5 * 1000L);` line that was used to wait until worker threads become idle. - Added a while loop with a 5-second timeout to actively check for the condition of fewer than 50 active worker threads. - Updated test annotations. Benefits: This change makes the test more robust by actively checking the condition instead of relying on a fixed sleep time. It also aligns with the modern testing approach and ensures the test does not hang indefinitely.
CodeLtDave
force-pushed
the
WorkerPoolTest
branch
from
77e0268
to
146c6a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaced a 5-second sleep used to wait for worker threads to become idle in the WorkerPoolTest with a while loop. This change includes a timeout of 5 seconds to check when there are fewer than 50 workers, making the test more responsive and reliable.
Changes:
Thread.sleep(5 * 1000L);line that was used to wait until worker threads become idle.Benefits:
This change makes the test more robust by actively checking the condition instead of relying on a fixed sleep time. It also aligns with the modern testing approach and ensures the test does not hang indefinitely.