Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Use google-java-format for Java formatting #624

Merged
merged 2 commits into from
Sep 6, 2023
Merged

all: Use google-java-format for Java formatting #624

merged 2 commits into from
Sep 6, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Feb 12, 2023

No description provided.

@fmeum fmeum force-pushed the google-java-format branch 2 times, most recently from bba2cac to 5e9b65f Compare February 13, 2023 08:14
@fmeum fmeum force-pushed the google-java-format branch from 5e9b65f to 6e48b5c Compare August 24, 2023 10:40
@fmeum fmeum marked this pull request as ready for review August 24, 2023 12:48
@fmeum fmeum requested a review from a team August 24, 2023 12:48
@fmeum fmeum force-pushed the google-java-format branch from 6e48b5c to 099076e Compare August 24, 2023 12:52
bertschneider
bertschneider approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at all the proposed changes, but the ones I saw mostly looked fine / better than before to me. Some unexpected new lines in String literals, nothing serious. IMHO we can go ahead with this.

@fmeum fmeum force-pushed the google-java-format branch from 099076e to 30b6e66 Compare September 6, 2023 13:44
@fmeum fmeum force-pushed the google-java-format branch from 30b6e66 to b29dced Compare September 6, 2023 13:50
@fmeum fmeum enabled auto-merge (rebase) September 6, 2023 13:51
@fmeum fmeum merged commit fb22ffa into main Sep 6, 2023
12 checks passed
@fmeum fmeum deleted the google-java-format branch September 6, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertschneider bertschneider bertschneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @bertschneider