Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and remove dependencies #220

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Update and remove dependencies #220

merged 4 commits into from
Oct 21, 2021

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 21, 2021

Ideally, all our prod dependencies in repositories.bzl would link to stable release archives, which won't change even when GitHub updates their archiver. But most dependencies don't offer such archives and git_repository either emits warnings about missing shallow_since or risks breaking builds due to bazelbuild/bazel#10292. No good solution here, so switch to releases where possible and leave the rest as is.

@fmeum fmeum enabled auto-merge (rebase) October 21, 2021 07:54
@fmeum fmeum force-pushed the switch-to-releases branch from 21d1612 to 2c88878 Compare October 21, 2021 08:08
fmeum added 4 commits October 21, 2021 10:13
bazel_common has no releases and rules_jvm_external exposes the only
part of it that we need, javadoc generation.
@fmeum fmeum force-pushed the switch-to-releases branch from 2c88878 to d94a221 Compare October 21, 2021 08:14
@fmeum fmeum merged commit 09c56b9 into main Oct 21, 2021
@fmeum fmeum deleted the switch-to-releases branch October 21, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant