Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFP-506] Add pr backend linter #507

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Conversation

w1stler
Copy link
Member

@w1stler w1stler commented Jan 11, 2023

Story / Bug id:

507

Description:

Added PR linter for backend

Copy link
Member

@arturtamborski arturtamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is now looking pretty good, just missing a few details (see suggestion).

.github/workflows/pr_linting.yml Outdated Show resolved Hide resolved
@Deelite34
Copy link

Deelite34 commented Feb 8, 2023

I had a look at this PR.
PR itself is fine, however as I found out, the issue with github action linting failing lies within lint backend action in actions repository.
It seems that the latest version of black is being used there, despite 22.12.0 version being intended to be used, in result causing this problem.
To fix this inconsistency and use 22.12.0 properly, set version parameter in actions repo, then I think new release needs to be created there, and used in here in this github action file. I've tested and got linting action to pass on a fork.
source

    - uses: psf/[email protected]
      with:
        version: "22.12.0"
        src: backend

@w1stler w1stler merged commit fe0ae2a into CodeForPoznan:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants