Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scrollSelectionToVisible
to match macOS precedence. It now:Note that Xcode, Zed, Vim, and Emacs do not move the cursor when using the page up/down keys. Instead they only move the viewport, which is what I've emulated here. VSCode is different, and moves the cursor when using page up/down. However I believe this is actually a bug in VSCode since every other editor I can find uses page up/down as scroll commands rather than cursor ones.
Related Issues
Checklist
Screenshots
Example app, moving around the document using page up/down and extending the selection by adding the shift key.
Screen.Recording.2024-06-15.at.6.27.10.PM.mov