Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Text selection with round corners #2

Open
wayou opened this issue May 19, 2022 · 5 comments
Open

✨ Text selection with round corners #2

wayou opened this issue May 19, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@wayou
Copy link

wayou commented May 19, 2022

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Text selection with round corner like in VSCode.

Describe alternatives you've considered

VSCode

Additional context

Screen Shot 2022-05-19 at 13 00 29

@wayou wayou added the enhancement New feature or request label May 19, 2022
@ghost
Copy link

ghost commented May 19, 2022

Hi @wayou, this feature sounds like a great idea, but we need consistency throughout our app and it is supposed to have a mimicked UI of Xcode. Xcode doesn't have round text selection. I might reconsider opening a PR for this if you tell me why we need round text selection. Every CodeEdit feature is backed by why it was implemented. Also, please provide a detailed response for each question, not just a few words.

@austincondiff
Copy link
Contributor

Thank you for your suggestion @wayou. This looks very nice and would make a great addition to CodeEdit. As this is not the default behavior of Xcode, if we did something like this it would need to be under a togglable setting disabled by default.

@maxsuaudeau Anyone is more than welcome to open an issue as long as it pertains to forward development of the project which this issue does.

@ghost
Copy link

ghost commented May 19, 2022

@austincondiff oh ok

@CodeEditApp CodeEditApp deleted a comment May 19, 2022
@austincondiff austincondiff changed the title Text selection with round corner ✨ Text selection with round corner May 19, 2022
@austincondiff austincondiff changed the title ✨ Text selection with round corner ✨ Text selection with round corners May 19, 2022
@0xWDG
Copy link

0xWDG commented May 19, 2022

i think if we implement this feature, it needs to be disabled by default.
See this stack overflow post, it might help https://stackoverflow.com/questions/16362407/nsattributedstring-background-color-and-rounded-corners

@wayou
Copy link
Author

wayou commented May 20, 2022

Hi @maxsuaudeau, glad to hear your reply. I'm long for such an editor with native experience and Xcode like well designed UI. But Xcode lacks of some convenient behavior like rich language support, format on save, etc.

I think the round text selection looks so great which is much more mac style, so I wonder if we can have it in CodeEdit.

@austincondiff austincondiff transferred this issue from CodeEditApp/CodeEdit Jun 28, 2022
@austincondiff austincondiff transferred this issue from CodeEditApp/CodeEditSourceEditor Dec 20, 2023
EstebanBorai pushed a commit that referenced this issue Feb 12, 2024
[feat]: Added python language support for tree-sitter highlighting
@thecoolwinter thecoolwinter self-assigned this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Todo
Development

No branches or pull requests

4 participants